sdk: fix langtag constraints in LangStringSet#478
Merged
Conversation
Previously the LangStringSet checked language tags that were added to match the format of xx or xx-XX. This did not follow the documented behavior, which requires all IETF BCP 47 conform language tags to be accepted. These changes replaced the previous constraint check, with a check by regular expression, following the IETF BCP 47 standard. Fixes eclipse-basyx#157
The langtag check of ITEF BCP 47 format from the aas-core project was not following the RFC 5646 precisely in two minor important points. These deviations are now corrected, so the check strictly follows the syntax described in the standard.
Previous change ignored case-insensivity of the abnf grammer of the BCP 47 standard. This change aligns the regex check with the one generated from https://github.com/aas-core-works/abnf-to-regexp/blob/main/test_data/nested-python/bcp47/grammar.abnf.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the LangStringSet checked language tags that were added
to match the simple format of xx or xx-XX. This did not follow the
documented behavior, which requires all
IETF BCP 47conformlanguage tags to be accepted.
These changes replaced the previous constraint check, with a
check by regular expression following the pattern described in
RFC 5646.
Fixes #157