Skip to content

Fix LocalFileIdentifiableStore: count and iterate only .json store files #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
s-heppner merged 4 commits into from
May 14, 2026
Merged

Fix LocalFileIdentifiableStore: count and iterate only .json store files #507

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
74e332e
fix: LocalFileIdentifiableStore.__len__ count only .json files
zrgt May 5, 2026
8feebf0
fix: LocalFileIdentifiableStore.__iter__ filter non-.json files and u…
zrgt May 5, 2026
effc30c
fix: case-insensitive .json filter in __len__, strengthen test
zrgt May 7, 2026
9bbbeb9
merge: incorporate fix/b6-local-file-iter into fix/b10-local-file-len
zrgt May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/basyx/aas/backend/local_file.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ def __len__(self) -> int:
:return: The number of objects (determined from the number of documents)
"""
logger.debug("Fetching number of documents from database ...")
return len(os.listdir(self.directory_path))
return sum(1 for f in os.listdir(self.directory_path) if f.endswith(".json"))
Comment thread
zrgt marked this conversation as resolved.
Outdated

def __iter__(self) -> Iterator[model.Identifiable]:
"""
Expand Down
13 changes: 13 additions & 0 deletions sdk/test/backend/test_local_file.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,19 @@ def test_key_errors(self) -> None:
self.assertEqual("'No AAS object with id https://example.org/Test_Submodel exists in "
"local file database'", str(cm.exception))

def test_len_ignores_non_json_files(self) -> None:
example_data = create_full_example()
for item in example_data:
self.identifiable_store.add(item)
self.assertEqual(5, len(self.identifiable_store))

# Stray files must not be counted
stray = os.path.join(store_path, ".DS_Store")
with open(stray, "w") as f:
f.write("stray")
self.assertEqual(5, len(self.identifiable_store))
os.remove(stray)

def test_reload_discard(self) -> None:
# Load example submodel
example_submodel = create_example_submodel()
Expand Down
Loading