Skip to content

fix(server): return 400 on malformed assetIds query parameter (#502) #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SAY-5 wants to merge 1 commit into from
Closed

fix(server): return 400 on malformed assetIds query parameter (#502) #537

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions server/app/interfaces/repository.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,9 +255,17 @@ def _get_shells(self, request: Request) -> Tuple[Iterator[model.AssetAdministrat

for asset_id in asset_ids:
asset_id_json = base64url_decode(asset_id)
asset_dict = json.loads(asset_id_json)
name = asset_dict["name"]
value = asset_dict["value"]
try:
asset_dict = json.loads(asset_id_json)
except json.JSONDecodeError as e:
raise BadRequest(f"Invalid assetIds query parameter: {e}") from e
if not isinstance(asset_dict, dict):
raise BadRequest("Invalid assetIds query parameter: expected a JSON object.")
try:
name = asset_dict["name"]
value = asset_dict["value"]
except KeyError as e:
raise BadRequest(f"Invalid assetIds query parameter: missing field {e}") from e

if name == "specificAssetId":
decoded_specific_id = HTTPApiDecoder.json_list(value, model.SpecificAssetId,
Expand Down