Refactoring Pull Request CI#599
Draft
paul-gerber-svg wants to merge 20 commits into
Draft
Conversation
Renaming CI definition file to PR (Pull Request) and change trigger to only run once on pull request. Also prevent concurrent runs. For testing pip caching, commented out jobs except a sample one.
Previously the pull_request pipeline did only test the docker image build for the repository server variant. We introduce a matrix job to run all three variants - repository - discovery - registry
Previously the docker daemon was used to determine if a docker container is alive. This is a weak criterion as this is already checked by the "Wait for container and sever initialization" step. We changed the liveness check to rely on the `/description` endpoint that all services are required to implement. A status `200 OK` is interpreted as alive. The `X_API_VERSION` that is necessary for the path of the curl call, is introduced as environment variable.
Previously we checked in the pull_request CI only that all `pyproject.toml` files requrire a python version that lies in bounds with `X_PYTHON_MIN_VERSION` and `X_PYTHON_MAX_VERSION`. We extended the check to also check the `Dockerfile` of the server directory.
This reverts commit 0344def.
Temporarilly, the version is set in the `pyproject.toml` files.
Test a composite action to reduce duplication
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Rename CI File to PR (Pull Request)
Implement Changes from CI: Reduce Action runs via trigger fix, concurrency, path filtering, and pip caching #518
*-packageto align with release pipelineFix Schema curl call CI: Fetching schemas via
cURLfails #547.aas-specs-metamodeland altered content of 'AAS_SPECS_RELEASE_TAG' tov3.1.2Delete commented server-test
Remove
sudo apt-get install –y bash gitfromrepository-check-copyrightubuntu-latestrunner (source)Remove Explicit Shell Defines
Restrict jobs to read-only access by default
Pin
gh-actionswith digestNode.js 24Check Python Versions in
DockerfileExpandcheck-python-versionsCI test to include Dockerfiles #480etc/scripts/check_python_versions_coincide.pyto also check dockerfilesFixes #518, #547, #480