Skip to content

Support target extended-remote launch connecting to gdbserver started… #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
fzuuzf wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Support target extended-remote launch connecting to gdbserver started… #496

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions src/desktop/GDBTargetDebugSession.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,11 +265,15 @@ export class GDBTargetDebugSession extends GDBDebugSession {
await this.setupCommonLoggerAndBackends(args);
this.initializeSessionArguments(args);

this.isAttach = true;
if (request === 'launch') {
const launchArgs = args as TargetLaunchRequestArguments;
await this.startGDBServer(launchArgs);
if (args.target?.type !== 'extended-remote') {
const launchArgs = args as TargetLaunchRequestArguments;
await this.startGDBServer(launchArgs);
} else
this.isAttach = false;
}
await this.startGDBAndAttachToTarget(response, args);
await this.startGDBAndConnectToGDBSERVER(response, args);
}

protected async launchRequest(
Expand Down Expand Up @@ -632,7 +636,7 @@ export class GDBTargetDebugSession extends GDBDebugSession {
}
}

protected async startGDBAndAttachToTarget(
protected async startGDBAndConnectToGDBSERVER(
response: DebugProtocol.AttachResponse | DebugProtocol.LaunchResponse,
args: TargetAttachRequestArguments
): Promise<void> {
Expand All @@ -641,7 +645,6 @@ export class GDBTargetDebugSession extends GDBDebugSession {
}
const target = args.target;
try {
this.isAttach = true;
// Start GDB process
this.logGDBRemote(`spawn GDB\n`);
await this.spawn(args);
Expand Down