Handle memory notifications#533
Conversation
jreineckearm
left a comment
There was a problem hiding this comment.
Tested changes and events are sent as expected. There seems however to be an issue with Memory Inspector reading updated memory correctly but not displaying the changes. To be looked at separately and outside the scope of this PR.
My only point is coming back to Asim's comment about the initialize request: it's true that the GDB adapter doesn't need to set anything in its response. But the point of the client sending capabilities is to announce what it's able to deal with. Hence, we strictly speaking should only send the memory event if the client announces support (to digest it).
In reality, I'd expect a client to just ignore an event if not supported. Hence, I am good to merge as is to move forward.
But for completeness, we should add a small follow-up PR that makes sending memory events conditional based on received capabilities. Could you please take care of that, @omarArm ?
Should solve #526
Handling GDB memory notifications by sending a DAP memory event.