Skip to content

Handle memory notifications#533

Merged
jreineckearm merged 6 commits into
eclipse-cdt-cloud:mainfrom
omarArm:handleMemoryNotify
May 20, 2026
Merged

Handle memory notifications#533
jreineckearm merged 6 commits into
eclipse-cdt-cloud:mainfrom
omarArm:handleMemoryNotify

Conversation

@omarArm

@omarArm omarArm commented May 8, 2026

Copy link
Copy Markdown
Contributor

Should solve #526

Handling GDB memory notifications by sending a DAP memory event.

@omarArm omarArm requested review from asimgunes and jonahgraham May 8, 2026 06:42

@asimgunes asimgunes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @omarArm , this is a good update, I just pointed out some potential problems.

Comment thread src/gdb/GDBDebugSessionBase.ts
Comment thread src/gdb/GDBDebugSessionBase.ts Outdated
@omarArm omarArm requested review from asimgunes and jreineckearm May 13, 2026 08:28

@jreineckearm jreineckearm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested changes and events are sent as expected. There seems however to be an issue with Memory Inspector reading updated memory correctly but not displaying the changes. To be looked at separately and outside the scope of this PR.

My only point is coming back to Asim's comment about the initialize request: it's true that the GDB adapter doesn't need to set anything in its response. But the point of the client sending capabilities is to announce what it's able to deal with. Hence, we strictly speaking should only send the memory event if the client announces support (to digest it).

In reality, I'd expect a client to just ignore an event if not supported. Hence, I am good to merge as is to move forward.

But for completeness, we should add a small follow-up PR that makes sending memory events conditional based on received capabilities. Could you please take care of that, @omarArm ?

@jreineckearm jreineckearm merged commit 6d4cc10 into eclipse-cdt-cloud:main May 20, 2026
4 checks passed
@cwalther

cwalther commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

But for completeness, we should add a small follow-up PR that makes sending memory events conditional based on received capabilities. Could you please take care of that, @omarArm ?

Done in 2ccafaf as part of #544.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants