Skip to content

Handle memory notifications #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
omarArm wants to merge 6 commits into
base: main
Choose a base branch
from
+33 −0
Open

Handle memory notifications #533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7450074
sending a memory event on memory-changed notification
omarArm May 7, 2026
b807683
updating tests to include testing memory events
omarArm May 7, 2026
56ba4c8
adding curly braces around case scope and removing unneeded code
omarArm May 7, 2026
6e1131f
protecting parseInt function
omarArm May 8, 2026
c2dab69
running prettier
omarArm May 8, 2026
204dfa1
sending a warning message if length is 0
omarArm May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/gdb/GDBDebugSessionBase.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import {
Logger,
logger,
LoggingDebugSession,
MemoryEvent,
OutputEvent,
Scope,
Source,
Expand Down Expand Up @@ -3167,6 +3168,18 @@ export abstract class GDBDebugSessionBase extends LoggingDebugSession {
case 'cmd-param-changed':
this.handleCmdParamChanged(notifyData);
break;
case 'memory-changed': {
Comment thread
omarArm marked this conversation as resolved.
let length = 0;
if (isNaN(notifyData.len)) {
logger.warn(
`GDB notify "memory-changed" has invalid length: ${notifyData.len}`
);
}
length = parseInt(notifyData.len);
const memoryEvent = new MemoryEvent(notifyData.addr, 0, length);
this.sendEvent(memoryEvent);
break;
}
default:
logger.warn(
`GDB unhandled notify: ${notifyClass}: ${JSON.stringify(
Expand Down
20 changes: 20 additions & 0 deletions src/integration-tests/mem.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,26 @@ describe('Memory Test Suite', function () {
verifyReadMemoryResponse(memory, newValue, addrOfArray);
});

it('can write memory and handle memory notifications from gdb', async function () {
const addrOfArray = parseInt(
(
await dc.evaluateRequest({
expression: '&array[0]',
frameId: frame.id,
})
).body.result
);
const memoryEvent = dc.waitForEvent('memory');
await dc.evaluateRequest({
expression: '>set array[0] = 0xde',
frameId: frame.id,
context: 'repl',
});
const output = await memoryEvent;
expect(parseInt(output.body.memoryReference)).eq(addrOfArray);
expect(output.body.count).eq(1);
});

it('fails when trying to write to read-only memory', async function () {
const addrOfArray = parseInt(
(
Expand Down
Loading