Skip to content

Add support set expression request#535

Merged
jreineckearm merged 7 commits into
eclipse-cdt-cloud:mainfrom
omarArm:addSetExpressionRequest
May 26, 2026
Merged

Add support set expression request#535
jreineckearm merged 7 commits into
eclipse-cdt-cloud:mainfrom
omarArm:addSetExpressionRequest

Conversation

@omarArm

@omarArm omarArm commented May 8, 2026

Copy link
Copy Markdown
Contributor

Supporting DAP setExpression request available here

Users can then set values of expressions available in the watch window.

@omarArm omarArm requested review from asimgunes and jonahgraham May 8, 2026 08:31
@omarArm omarArm requested a review from jreineckearm May 18, 2026 07:55

@jreineckearm jreineckearm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looking good, some minor comments. Giving it a try in the meanwhile

Comment thread src/gdb/GDBDebugSessionBase.ts Outdated
Comment thread src/gdb/GDBDebugSessionBase.ts
Comment thread src/integration-tests/evaluate.spec.ts

@jreineckearm jreineckearm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and did what it was supposed to do. Happy to approve once feedback has been addressed and no other reviewer feedback comes in by then.

@jreineckearm jreineckearm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! Good to go as far as I am concerned.
Waiting until Tuesday evening with merge to give other reviewers chance to comment.

@asimgunes asimgunes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I don't have any comments at this point. Thanks.

@jreineckearm jreineckearm merged commit f37569d into eclipse-cdt-cloud:main May 26, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants