Skip to content

Implement autoExpandLevel for EntryModel trees#1202

Merged
bhufmann merged 1 commit into
eclipse-cdt-cloud:masterfrom
williamsyang-work:expand-level-impl
Jun 17, 2025
Merged

Implement autoExpandLevel for EntryModel trees#1202
bhufmann merged 1 commit into
eclipse-cdt-cloud:masterfrom
williamsyang-work:expand-level-impl

Conversation

@williamsyang-work

@williamsyang-work williamsyang-work commented Jun 12, 2025

Copy link
Copy Markdown
Contributor

What it does

Add support for the autoExpandLevel flag to automatically collapse tree nodes beyond the specified depth level. When autoExpandLevel is set, nodes at depths greater than the specified level are automatically collapsed in the tree view.

Related to eclipse-cdt-cloud/tsp-typescript-client#130

How to test

What I did was comment out getCollapsedNodesFromAutoExpandLevel and add a replacement test call using different values for autoExpandLevel to ensure that it was working correctly for each value.

Follow-ups

No follow ups required.

Review checklist

  • As an author, I have thoroughly tested my changes and carefully followed the instructions in this template

@williamsyang-work williamsyang-work marked this pull request as ready for review June 13, 2025 18:32
@bhufmann

bhufmann commented Jun 16, 2025

Copy link
Copy Markdown
Contributor

Fixes #801

@bhufmann bhufmann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tsp-typescript-client 0.7.0 has been deployed. Please update the package.json file for traceviewer-base and traceviewer-react-components to this version.

I tested this change with trace server that with applied this setting. It works well:
eclipse-tracecompass/org.eclipse.tracecompass#289

@marcdumais-work

Copy link
Copy Markdown
Contributor

I updated tsp-typescript-client to 0.7.0 locally and tested with Bernd's trace server PR: eclipse-tracecompass/org.eclipse.tracecompass#289

Seems to work fine:

image

@williamsyang-work

Copy link
Copy Markdown
Contributor Author

tsp-typescript-client 0.7.0 has been deployed. Please update the package.json file for traceviewer-base and traceviewer-react-components to this version.

I tested this change with trace server that with applied this setting. It works well: eclipse-tracecompass/org.eclipse.tracecompass#289

tsp-typescript-client has been updated in the appropriate package.json files.

Add support for the autoExpandLevel flag to automatically collapse tree
nodes beyond the specified depth level. When autoExpandLevel is set, nodes
at depths greater than the specified level are automatically collapsed in
the tree view.

Related to eclipse-cdt-cloud/tsp-typescript-client#130

Signed-off-by: Will Yang <william.yang@ericsson.com>
@williamsyang-work

Copy link
Copy Markdown
Contributor Author

Fixed the linting errors (hopefully)

@marcdumais-work

Copy link
Copy Markdown
Contributor

IP Ticket to open:

ERROR: Found restricted dash-licenses results that are not filtered by configuration! X npm/npmjs/-/tsp-typescript-client/0.7.0

ATM, when I run dash-licenses locally, to create the IP ticket, it fails (when querying clearlydefined). I will try again tomorrow.

@marcdumais-work

marcdumais-work commented Jun 17, 2025

Copy link
Copy Markdown
Contributor

A review is required for npm/npmjs/-/allure-commandline/2.34.0.
A review request already exists https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/21566 .
A review is required for npm/npmjs/-/tsp-typescript-client/0.7.0.
A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/22029

Note: npm/npmjs/-/allure-commandline/2.34.0 will be ignored when the PR is merged (it's excluded from consideration in a recent commit, since believed to be license-compatible and being reviewed by the EF IP team).

@marcdumais-work

marcdumais-work commented Jun 17, 2025

Copy link
Copy Markdown
Contributor

@williamsyang-work would you rebase on latest master? I think the license check will then pass.

Update: seems you already are on the latest baseline - not sure why allure-commandline/2.34.0 came-up as a problem. Let me restart the license check and maybe it will pass

@marcdumais-work

Copy link
Copy Markdown
Contributor

All good for the license check.

@marcdumais-work marcdumais-work left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @williamsyang-work !

I quickly tried the new feature in the vscode extension, using yarn link, and it worked well too:

image

@bhufmann bhufmann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for adding this.

@bhufmann bhufmann merged commit 191560a into eclipse-cdt-cloud:master Jun 17, 2025
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants