Fix field name to 'required` of ConfigurationParameterDescriptor#145
Merged
bhufmann merged 1 commit intoeclipse-cdt-cloud:masterfrom Oct 6, 2025
Merged
Fix field name to 'required` of ConfigurationParameterDescriptor#145bhufmann merged 1 commit intoeclipse-cdt-cloud:masterfrom
bhufmann merged 1 commit intoeclipse-cdt-cloud:masterfrom
Conversation
The TSP specifies `required` instead of `isRequired`. This commit aligns the implementation with the specification. See also: eclipse-tracecompass-incubator/org.eclipse.tracecompass.incubator#246 Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
PatrickTasse
approved these changes
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TSP specifies
requiredinstead ofisRequired. This commit aligns the implementation with the specification.What it does
Fix field name to 'required
of ConfigurationParameterDescriptor. The TSP specifiesrequiredinstead ofisRequired`. This commit aligns the implementation with the specification.See also:
eclipse-tracecompass-incubator/org.eclipse.tracecompass.incubator#246
How to test
There is on unit test in this repo that verifies this (
configurationSourceTypesoftsp-client-tests.ts) which should run successfully now.Follow-ups
Review checklist