Skip to content

Fix field name to 'required` of ConfigurationParameterDescriptor #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bhufmann merged 1 commit into from
Oct 6, 2025
Merged

Fix field name to 'required` of ConfigurationParameterDescriptor #145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tsp-typescript-client/fixtures/tsp-client/fetch-configuration-sources-0.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"keyName": "path",
"description": "path description",
"dataType": "STRING",
"isRequired": "True"
"required": "True"
},
{
"keyName": "test1"
Expand Down
2 changes: 1 addition & 1 deletion tsp-typescript-client/src/models/configuration-source.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,5 +55,5 @@ export interface ConfigurationParameterDescriptor {
/**
* If parameter needs to in the query parameters or not. Default is false.
*/
isRequired?: boolean;
required?: boolean;
}
4 changes: 2 additions & 2 deletions tsp-typescript-client/src/protocol/tsp-client.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,12 +539,12 @@ describe('HttpTspClient Deserialization', () => {
expect(paramDesc[0].keyName).toEqual('path');
expect(paramDesc[0].description).toEqual('path description');
expect(paramDesc[0].dataType).toEqual('STRING');
expect(paramDesc[0].isRequired).toBeTruthy();
expect(paramDesc[0].required).toBeTruthy();

expect(paramDesc[1].keyName).toEqual('test1');
expect(paramDesc[1].description).toBeUndefined();
expect(paramDesc[1].dataType).toBeUndefined();
expect(paramDesc[1].isRequired).toBeUndefined();
expect(paramDesc[1].required).toBeUndefined();
expect(sourceTypes[0].schema).toBeUndefined();

expect(sourceTypes[1].parameterDescriptors).toBeUndefined();
Expand Down