Move ReadMemory/WriteMemory into adapter-capabilities

Since the ReadMemory/WriteMemory may be dependent upon the DAPs, move
into the adapter-capabilities.ts file.

Signed-off-by: Thor Thayer <thor.thayer@ericsson.com>

Author: WyoTwT

src/plugin/adapter-registry/adapter-capabilities.ts

@@ -18,6 +18,7 @@ import { DebugProtocol } from '@vscode/debugprotocol';
 import * as vscode from 'vscode';
 import { isDebugRequest, isDebugResponse } from '../../common/debug-requests';
 import { VariableRange } from '../../common/memory-range';
+import { ReadMemoryArguments, ReadMemoryResult, WriteMemoryArguments, WriteMemoryResult } from '../../common/messaging';
 import { MemoryDisplaySettingsContribution } from '../../common/webview-configuration';
 import { Logger } from '../logger';
 
@@ -35,6 +36,8 @@ export interface AdapterCapabilities {
     getMemoryDisplaySettings?(session: vscode.DebugSession): Promise<Partial<MemoryDisplaySettingsContribution>>;
     /** Initialize the trackers of this adapter's for the debug session. */
     initializeAdapterTracker?(session: vscode.DebugSession): vscode.DebugAdapterTracker | undefined;
+    readMemory?(session: vscode.DebugSession, params: ReadMemoryArguments): Promise<ReadMemoryResult>;
+    writeMemory?(session: vscode.DebugSession, params: WriteMemoryArguments): Promise<WriteMemoryResult>;
 }
 
 export type WithChildren<Original> = Original & { children?: Array<WithChildren<DebugProtocol.Variable>> };
@@ -135,6 +138,10 @@ export class AdapterVariableTracker implements vscode.DebugAdapterTracker {
 
     /** Resolves the size of a given variable in bytes within the current context. */
     getSizeOfVariable?(variableName: string, session: vscode.DebugSession): Promise<bigint | undefined>;
+
+    readMemory?(session: vscode.DebugSession, params: ReadMemoryArguments): Promise<ReadMemoryResult>;
+
+    writeMemory?(session: vscode.DebugSession, params: WriteMemoryArguments): Promise<WriteMemoryResult>;
 }
 
 export class VariableTracker implements AdapterCapabilities {

src/plugin/memory-provider.ts

@@ -49,7 +49,10 @@ export class MemoryProvider {
     }
 
     public async readMemory(args: DebugProtocol.ReadMemoryArguments): Promise<ReadMemoryResult> {
-        return sendRequest(this.sessionTracker.assertDebugCapability(this.sessionTracker.activeSession, 'supportsReadMemoryRequest', 'read memory'), 'readMemory', args);
+        const session = this.sessionTracker.assertDebugCapability(this.sessionTracker.activeSession, 'supportsReadMemoryRequest', 'read memory');
+        const handler = this.adapterRegistry?.getHandlerForSession(session.type);
+        if (handler?.readMemory) { return handler.readMemory(session, args); }
+        return sendRequest(session, 'readMemory', args);
     }
 
     public async writeMemory(args: DebugProtocol.WriteMemoryArguments): Promise<WriteMemoryResult> {
@@ -63,6 +66,14 @@ export class MemoryProvider {
             // if our custom handler is active, let's fire the event ourselves
             this.sessionTracker.fireSessionEvent(session, 'memory-written', { memoryReference: args.memoryReference, offset, count });
         };
+        const handler = this.adapterRegistry?.getHandlerForSession(session.type);
+        if (handler?.writeMemory) {
+            return handler.writeMemory(session, args).then(response => {
+                // The memory event is handled before we got here, if the scheduled event still exists, we need to handle it
+                this.scheduledOnDidMemoryWriteEvents[args.memoryReference]?.(response);
+                return response;
+            });
+        };
 
         return sendRequest(session, 'writeMemory', args).then(response => {
             // The memory event is handled before we got here, if the scheduled event still exists, we need to handle it