Skip to content

Commit 91f8f9b

Browse files
committed
TraceServer: Add resetting to stop command error
Refine the error message for the stop command, adding an indication of being about to reset. This hints the user about any next start command being hopeful, despite this apparently failed stop. This helps the case where VS Code/Codium exits without a clean server stop. Exiting so does automatically stop the said server, but the code that properly resets the internal workspace state is likely not reached by that exiting act. Theia Blueprint for that matter does properly reach that reset code, upon exiting and having to auto-stop the server. And the third use case, pertaining to PR #1's openvscode-server use, does rely on this workspace state to stop a server started before reopening the browser client tab. Contributes to fixing #8. Signed-off-by: Marco Miller <marco.miller@ericsson.com>
1 parent 5855d1d commit 91f8f9b

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

src/trace-server.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ export class TraceServer {
5353
},
5454
async progress => {
5555
progress.report({ message: 'Stopping...' });
56-
const message = prefix + ' stopping' + suffix;
56+
const message = prefix + ' stopping' + suffix + ' Resetting.';
5757
treeKill(pid, error => {
5858
if (error) {
5959
this.showError(message);

0 commit comments

Comments
 (0)