changing No data available message to a wheel while loading trees#19
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a loading-aware empty state to the tree table so users see a spinner while data/columns are still being resolved.
Changes:
- Introduced a
loading?: booleanprop with a default derived fromdataSource/columnDefinitionsbeing undefined. - Replaced the “No data available.” empty state with a spinner when
loadingis true. - Added CSS to theme the Ant Design spinner dots in the empty table state.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| style/tree/tree.css | Styles Ant Design empty-table spinner dots and adjusts a selector formatting. |
| src/tree/browser/tree.tsx | Adds loading prop and renders a spinner in renderEmpty() while loading. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jreineckearm
left a comment
There was a problem hiding this comment.
Code changes look reasonable as far as I can judge.
Please have a look at copilot feedback (especially the formatting feedback). I don't fully understand the complaint about loading. At the same time I don't see how you will use in peripheral inspector. That part would help to get the full picture.
|
@jreineckearm done |
Fixes eclipse-cdt-cloud/vscode-peripheral-inspector#65