Adapt target platform definition for using release versions#260
Merged
Conversation
ghentschke
approved these changes
Feb 20, 2024
ghentschke
left a comment
ghentschke
left a comment
Contributor
There was a problem hiding this comment.
LGTM @travkin79 Thank you!
Contributor
|
They have made the release prior the update LSP4E to LSP4J 0.22.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wondered why my last PR #256 didn't compile in the first place. It turns out, it's because the target definition file uses some repository locations pointing to snapshots instead of releases. I suppose that should be changed before releasing CDT LSP 1.1.0, right @ghentschke? This PR should do exactly that.
PR #256 didn't compile, because the target definition file uses snapshot versions for LSP4E. The latest LSP4E snapshot version uses LSP4J version
[0.22.0,0.23.0), but the latest LSP4E release version 0.24.8 uses LSP4J version[0.21.0,0.22.0). These LSP4J versions are incompatible (due to some classes that were moved from one package to another). Since CDT LSP needs LSP4E 0.24.8, I think, we have to stick with LSP4J version 0.21.0.I am not sure about the Docker repository location
https://download.eclipse.org/linuxtools/updates-docker-nightly, depending on what it is used for, it may need to be replaced with a release versions repo, too.