Gdb Manual Remote launch targets for CoreBuild projects (#1222)

* Gdb Manual Remote launch targets for CoreBuild projects

Support the Gdb Remote TCP and Serial launch targets for CoreBuild
projects.  A new non-public LaunchConfiguration type is added, that is
working with the same launch descriptor type as CoreBuild Local
projects. Also a new LaunchConfigurationProvider that supports the Gdb
Remote TCP and Serial targets is added.

It makes use of the launch delegate
org.eclipse.cdt.dsf.gdb.launching.GdbTargetedLaunchDelegate, which is
also used for standard GDB (DSF) Manual Remote Debugging launch
configurations for TCP and Serial connections.

For the user is appears as if there is a single CoreBuild launch
configuration that adapts dynamically to the launch target, while in
reality there is a separate launch configuration for each target.

Also cleanup up a bit CoreBuildGenericLaunchConfigProvider and
fixed a bug in launchTargetRemoved().


* Disable the GDB connection fields for CoreBuild launch configurations.

Launch Target settings have precedence over Launch Configuration
settings. Multiple Launch Configurations can use the same Launch
Target. Disable settings controlled by the Launch Target to avoid
inconsistent settings.

For non-CoreBuild GDB remote launch configurations the settings remain
editable.  These launch configurations can be launched without launch
bar.

* Documentation Core Build debug remote target.

* New launch configuration name based on target name.

The new launch configuration name is only based on the target name and
the type (tcp or serial).
Changing a connection parameter will not result in a new launch
configuration.

Fixes #1168

Author: ewaterlander

debug/org.eclipse.cdt.debug.core/META-INF/MANIFEST.MF

@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.cdt.debug.core; singleton:=true
-Bundle-Version: 9.0.200.qualifier
+Bundle-Version: 9.0.300.qualifier
 Bundle-Activator: org.eclipse.cdt.debug.core.CDebugCorePlugin
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin

debug/org.eclipse.cdt.debug.core/src/org/eclipse/cdt/debug/core/launch/CoreBuildGenericLaunchConfigProvider.java

@@ -1,3 +1,13 @@
+/*******************************************************************************
+ * Copyright (c) 2017 - 2025 QNX Software Systems and others.
+ *
+ * This program and the accompanying materials
+ * are made available under the terms of the Eclipse Public License 2.0
+ * which accompanies this distribution, and is available at
+ * https://www.eclipse.org/legal/epl-2.0/
+ *
+ * SPDX-License-Identifier: EPL-2.0
+ *******************************************************************************/
 package org.eclipse.cdt.debug.core.launch;
 
 import java.util.HashMap;
@@ -42,6 +52,12 @@ public ILaunchConfigurationType getLaunchConfigurationType(ILaunchDescriptor des
 				.getLaunchConfigurationType(CoreBuildGenericLaunchConfigDelegate.TYPE_ID);
 	}
 
+	private String getTargetConfigKey(ILaunchTarget target) {
+		String os = target.getAttribute(ILaunchTarget.ATTR_OS, EMPTY);
+		String arch = target.getAttribute(ILaunchTarget.ATTR_ARCH, EMPTY);
+		return os + '.' + arch;
+	}
+
 	@Override
 	public ILaunchConfiguration getLaunchConfiguration(ILaunchDescriptor descriptor, ILaunchTarget target)
 			throws CoreException {
@@ -54,10 +70,7 @@ public ILaunchConfiguration getLaunchConfiguration(ILaunchDescriptor descriptor,
 				configs.put(project, projectConfigs);
 			}
 
-			String os = target.getAttribute(ILaunchTarget.ATTR_OS, EMPTY);
-			String arch = target.getAttribute(ILaunchTarget.ATTR_ARCH, EMPTY);
-			String targetConfig = os + '.' + arch;
-			config = projectConfigs.get(targetConfig);
+			config = projectConfigs.get(getTargetConfigKey(target));
 			if (config == null) {
 				config = createLaunchConfiguration(descriptor, target);
 			}
@@ -141,25 +154,20 @@ public void launchDescriptorRemoved(ILaunchDescriptor descriptor) throws CoreExc
 	@Override
 	public void launchTargetRemoved(ILaunchTarget target) throws CoreException {
 		// Any other targets have the same OS and ARCH?
-		String os = target.getAttribute(ILaunchTarget.ATTR_OS, EMPTY);
-		String arch = target.getAttribute(ILaunchTarget.ATTR_ARCH, EMPTY);
-
 		ILaunchTargetManager targetManager = CDebugCorePlugin.getService(ILaunchTargetManager.class);
 		for (ILaunchTarget t : targetManager.getLaunchTargets()) {
-			if (!target.equals(t) && os.equals(t.getAttribute(ILaunchTarget.ATTR_OS, EMPTY))
-					&& arch.equals(t.getAttribute(ILaunchTarget.ATTR_ARCH, EMPTY))) {
+			if (!target.equals(t) && getTargetConfigKey(target).equals(getTargetConfigKey(t))) {
 				// Yup, nothing to do then
 				return;
 			}
 		}
 
 		for (Entry<IProject, Map<String, ILaunchConfiguration>> projectEntry : configs.entrySet()) {
 			Map<String, ILaunchConfiguration> projectConfigs = projectEntry.getValue();
-			ILaunchConfiguration config = projectConfigs.get(os);
+			ILaunchConfiguration config = projectConfigs.get(getTargetConfigKey(target));
 			if (config != null) {
 				config.delete();
 			}
 		}
 	}
-
 }

doc/org.eclipse.cdt.doc.user/images/cbs_connection_serial.png

@@ -28,7 +28,7 @@ endif::[]
 // adoc files.
 // ENDOFHEADER
 
-== Debugging a project
+== Debugging a local target
 
 Debugging a CBS project is done via the xref:cbs_launchbar.adoc[Launch Bar]. Make
 sure the launch bar is installed and enabled.
@@ -79,3 +79,5 @@ On the *Source* tab extra paths outside the project folder can be
 defined to look for source code.
 
 image:cbs_launch_config_tab_debug.png[Launch configuration debug tab]
+
+icon:arrow-circle-right[] xref:cbs_debug_remote.adoc[Next: Debugging a remote target]