Make sure Launch Bar Manager sends event at a correct time#1486
Draft
DangMinhTam382 wants to merge 2 commits into
Draft
Make sure Launch Bar Manager sends event at a correct time#1486DangMinhTam382 wants to merge 2 commits into
DangMinhTam382 wants to merge 2 commits into
Conversation
When active descriptor changed, and fireActiveLaunchDescriptorChanged() is called, current active mode and target are out of sync. This puts listeners at risk of handling event with false data for the changed descriptor. Changed it so that only fire event when related fields are finished updating
Contributor
Author
|
Hi Mr. @betamaxbandit , Before making this PR official, could you take a quick look and let me know what you think? Thanks! |
Kummallinen
reviewed
Jun 30, 2026
| // Set active mode | ||
| syncActiveMode(); | ||
| // Send notifications | ||
| fireActiveLaunchDescriptorChanged(); |
Contributor
There was a problem hiding this comment.
Just moving this doesn't really solve the issue, the events for target & mode are still sent too early. This was why I suggested we create a new event that was for when any of them changed then we can just fire that once
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When active descriptor changed, and fireActiveLaunchDescriptorChanged() is called, current active mode and target are out of sync. This puts listeners at risk of handling event with false data for the changed descriptor.
Changed it so that only fire event when related fields are finished updating