Skip to content

Commit fd91e8e

Browse files
authored
fix(a11y): add workspace name to kebab menu aria-label (#1544)
Assisted-by: Claude Opus 4.6 Signed-off-by: Oleksii Orel <oorel@redhat.com>
1 parent d3f807a commit fd91e8e

3 files changed

Lines changed: 6 additions & 6 deletions

File tree

packages/dashboard-frontend/src/contexts/WorkspaceActions/Dropdown/__tests__/__snapshots__/index.spec.tsx.snap

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
exports[`WorkspaceActionsDropdown dropdown toggle snapshot 1`] = `
44
<button
55
aria-expanded={false}
6-
aria-label="Actions"
6+
aria-label="Actions for my-workspace"
77
className="pf-v6-c-menu-toggle pf-m-primary"
88
data-ouia-component-id="OUIA-Generated-MenuToggle-primary-1"
99
data-ouia-component-type="PF6/MenuToggle"
@@ -47,7 +47,7 @@ exports[`WorkspaceActionsDropdown dropdown toggle snapshot 1`] = `
4747
exports[`WorkspaceActionsDropdown kebab toggle snapshot 1`] = `
4848
<button
4949
aria-expanded={false}
50-
aria-label="Actions"
50+
aria-label="Actions for my-workspace"
5151
className="pf-v6-c-menu-toggle pf-m-plain"
5252
data-ouia-component-id="OUIA-Generated-MenuToggle-plain-1"
5353
data-ouia-component-type="PF6/MenuToggle"

packages/dashboard-frontend/src/contexts/WorkspaceActions/Dropdown/__tests__/index.spec.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ describe('WorkspaceActionsDropdown', () => {
6161
test('open dropdown', async () => {
6262
renderComponent(workspace, 'kebab-toggle');
6363

64-
const toggle = screen.queryByRole('button', { name: 'Actions' });
64+
const toggle = screen.queryByRole('button', { name: 'Actions for my-workspace' });
6565

6666
expect(toggle).toBeTruthy();
6767
expect(toggle).toHaveAttribute('data-testtype', 'kebab-toggle');
@@ -93,7 +93,7 @@ describe('WorkspaceActionsDropdown', () => {
9393
test('open dropdown', async () => {
9494
renderComponent(workspace, 'dropdown-toggle');
9595

96-
const toggle = screen.queryByRole('button', { name: 'Actions' });
96+
const toggle = screen.queryByRole('button', { name: 'Actions for my-workspace' });
9797

9898
expect(toggle).not.toBeNull();
9999
expect(toggle).toHaveAttribute('data-testtype', 'dropdown-toggle');

packages/dashboard-frontend/src/contexts/WorkspaceActions/Dropdown/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ class WorkspaceActionsDropdownComponent extends React.PureComponent<Props, State
7979
return (toggleRef: React.Ref<MenuToggleElement>) => (
8080
<MenuToggle
8181
ref={toggleRef}
82-
aria-label="Actions"
82+
aria-label={`Actions for ${workspace.name}`}
8383
data-testid={`${workspace.uid}-action-dropdown`}
8484
data-testtype="kebab-toggle"
8585
isDisabled={isDisabled}
@@ -96,7 +96,7 @@ class WorkspaceActionsDropdownComponent extends React.PureComponent<Props, State
9696
return (toggleRef: React.Ref<MenuToggleElement>) => (
9797
<MenuToggle
9898
ref={toggleRef}
99-
aria-label="Actions"
99+
aria-label={`Actions for ${workspace.name}`}
100100
data-testid={`${workspace.uid}-action-dropdown`}
101101
data-testtype="dropdown-toggle"
102102
isDisabled={isDisabled}

0 commit comments

Comments
 (0)