Accessibility issues cherry-pick#1560
Merged
Merged
Conversation
Assisted-by: Claude Sonnet 4.6 Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
…e label (#1547) The button's aria-label was "Restore from backup" while the visible text was "Restore Workspace", violating WCAG 2.5.3 (Label in Name). Removing the aria-label lets the visible text serve as the accessible name. Fixes: https://issues.redhat.com/browse/CRW-10720 Assisted-by: Claude Opus 4.6 (1M context) Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ab (#1556) WCAG 2.5.3 (Label in Name) — the Search input on the Backups tab had aria-label "Filter backups" while its visible placeholder was "Search". Rename to "Search backups" on both the TextInput and search Button. Align the Backups toolbar and table layout with the Active Workspaces tab by adding hidden checkbox elements that match the same DOM structure, ensuring pixel-perfect column alignment. Move the backup schedule label from the Backups toolbar to the page-level header so it is visible on both tabs. Remove force:true from BackupsView fetch calls so the 30s Redux cache prevents redundant API calls on tab switch. Add dedicated unit tests for BackupsListToolbar and remove redundant toolbar tests from BackupsTableView. Assisted-by: Claude Opus 4.6 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> # Conflicts: # packages/dashboard-frontend/src/pages/WorkspacesList/BackupsView/Toolbar/index.tsx
Contributor
|
Click here to review and test in web IDE: |
The test was looking for "Restore from Backup" (the old aria-label removed in #1547) instead of "Restore Workspace" (the visible text). Assisted-by: Claude Opus 4.6 (1M context) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1560 (linux/amd64, linux/arm64) kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1560", name: che-dashboard}]}}]" |
Contributor
|
/retest |
1 similar comment
Contributor
|
/retest |
svor
approved these changes
May 12, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, svor The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Cherry-picks of the following PRs from main:
Screenshot/screencast of this PR
What issues does this PR fix or reference?
Is it tested? How?
Release Notes
Docs PR