Skip to content

Backport fixes for WCAG 1.3.1 and WCAG 4.1.2 #1566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
svor merged 2 commits into from
May 14, 2026
+26 −7
Merged

Backport fixes for WCAG 1.3.1 and WCAG 4.1.2 #1566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d700d7
fix(a11y): fix invalid list structures in navigation and alert group …
olexii4 May 13, 2026
8977a27
fix(a11y): add role="img" to workspace status indicator span (WCAG 4.…
olexii4 May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions packages/dashboard-frontend/src/Layout/Navigation/RecentList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
* Red Hat, Inc. - initial API and implementation
*/

import { NavGroup, NavList } from '@patternfly/react-core';
import { NavGroup } from '@patternfly/react-core';
import React from 'react';

import { NavigationRecentItem } from '@/Layout/Navigation/RecentItem';
Expand Down Expand Up @@ -51,11 +51,9 @@ function NavigationRecentList(props: {
);
});
return (
<NavList>
<NavGroup title="RECENT WORKSPACES" style={{ marginTop: '25px' }}>
{recentWorkspaceItems}
</NavGroup>
</NavList>
<NavGroup title="RECENT WORKSPACES" style={{ marginTop: '25px' }}>
{recentWorkspaceItems}
</NavGroup>
);
}
NavigationRecentList.displayName = 'NavigationRecentListComponent';
Expand Down
6 changes: 5 additions & 1 deletion packages/dashboard-frontend/src/components/AppAlertGroup/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,11 @@ class AppAlertGroup extends React.PureComponent<Props, State> {
}

public render(): React.ReactElement {
return <AlertGroup isToast>{this.state.alerts.map(alert => this.getAlert(alert))}</AlertGroup>;
const { alerts } = this.state;
if (alerts.length === 0) {
return <></>;
}
return <AlertGroup isToast>{alerts.map(alert => this.getAlert(alert))}</AlertGroup>;
}
}

Expand Down
16 changes: 16 additions & 0 deletions ...src/components/Workspace/Status/Indicator/__tests__/__snapshots__/Indicator.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ exports[`Workspace indicator component Che Workspaces should render ERROR status
aria-label="Workspace status is ERROR"
className="statusIndicator"
data-testid="workspace-status-indicator"
role="img"
>
<span
className="pf-v6-c-icon pf-m-inline"
Expand Down Expand Up @@ -70,6 +71,7 @@ exports[`Workspace indicator component Che Workspaces should render RUNNING stat
aria-label="Workspace status is RUNNING"
className="statusIndicator"
data-testid="workspace-status-indicator"
role="img"
>
<span
className="pf-v6-c-icon pf-m-inline"
Expand Down Expand Up @@ -119,6 +121,7 @@ exports[`Workspace indicator component Che Workspaces should render STARTING sta
aria-label="Workspace status is STARTING"
className="statusIndicator"
data-testid="workspace-status-indicator"
role="img"
>
<span
className="pf-v6-c-icon pf-m-inline"
Expand Down Expand Up @@ -169,6 +172,7 @@ exports[`Workspace indicator component Che Workspaces should render STOPPED stat
aria-label="Workspace status is STOPPED"
className="statusIndicator"
data-testid="workspace-status-indicator"
role="img"
>
<span
className="pf-v6-c-icon pf-m-inline"
Expand Down Expand Up @@ -229,6 +233,7 @@ exports[`Workspace indicator component Che Workspaces should render STOPPING sta
aria-label="Workspace status is STOPPING"
className="statusIndicator"
data-testid="workspace-status-indicator"
role="img"
>
<span
className="pf-v6-c-icon pf-m-inline"
Expand Down Expand Up @@ -279,6 +284,7 @@ exports[`Workspace indicator component Deprecated workspaces should render "Depr
aria-label="Workspace status is Deprecated"
className="statusIndicator"
data-testid="workspace-status-indicator"
role="img"
>
<span
className="pf-v6-c-icon pf-m-inline"
Expand Down Expand Up @@ -328,6 +334,7 @@ exports[`Workspace indicator component DevWorkspaces should render FAILED status
aria-label="Workspace status is Failed"
className="statusIndicator"
data-testid="workspace-status-indicator"
role="img"
>
<span
className="pf-v6-c-icon pf-m-inline"
Expand Down Expand Up @@ -377,6 +384,7 @@ exports[`Workspace indicator component DevWorkspaces should render FAILING statu
aria-label="Workspace status is Failing"
className="statusIndicator"
data-testid="workspace-status-indicator"
role="img"
>
<span
className="pf-v6-c-icon pf-m-inline"
Expand Down Expand Up @@ -427,6 +435,7 @@ exports[`Workspace indicator component DevWorkspaces should render RUNNING statu
aria-label="Workspace status is Running"
className="statusIndicator"
data-testid="workspace-status-indicator"
role="img"
>
<span
className="pf-v6-c-icon pf-m-inline"
Expand Down Expand Up @@ -476,6 +485,7 @@ exports[`Workspace indicator component DevWorkspaces should render STOPPED statu
aria-label="Workspace status is Stopped"
className="statusIndicator"
data-testid="workspace-status-indicator"
role="img"
>
<span
className="pf-v6-c-icon pf-m-inline"
Expand Down Expand Up @@ -536,6 +546,7 @@ exports[`Workspace indicator component SCC Mismatch should render normal status
aria-label="Workspace status is Running"
className="statusIndicator"
data-testid="workspace-status-indicator"
role="img"
>
<span
className="pf-v6-c-icon pf-m-inline"
Expand Down Expand Up @@ -585,6 +596,7 @@ exports[`Workspace indicator component SCC Mismatch should render normal status
aria-label="Workspace status is Stopped"
className="statusIndicator"
data-testid="workspace-status-indicator"
role="img"
>
<span
className="pf-v6-c-icon pf-m-inline"
Expand Down Expand Up @@ -645,6 +657,7 @@ exports[`Workspace indicator component SCC Mismatch should render normal status
aria-label="Workspace status is Stopped"
className="statusIndicator"
data-testid="workspace-status-indicator"
role="img"
>
<span
className="pf-v6-c-icon pf-m-inline"
Expand Down Expand Up @@ -705,6 +718,7 @@ exports[`Workspace indicator component SCC Mismatch should render warning for ST
aria-label="Workspace status is Stopped"
className="statusIndicator"
data-testid="workspace-status-indicator"
role="img"
>
<span
className="pf-v6-c-icon pf-m-inline"
Expand Down Expand Up @@ -782,6 +796,7 @@ exports[`Workspace indicator component SCC Mismatch should render warning triang
aria-label="Workspace status has SCC mismatch warning"
className="statusIndicator"
data-testid="workspace-status-indicator"
role="img"
>
<span
className="pf-v6-c-icon pf-m-inline"
Expand Down Expand Up @@ -831,6 +846,7 @@ exports[`Workspace indicator component should render default status correctly 1`
aria-label="Workspace status is STOPPING"
className="statusIndicator"
data-testid="workspace-status-indicator"
role="img"
>
<span
className="pf-v6-c-icon pf-m-inline"
Expand Down
1 change: 1 addition & 0 deletions packages/dashboard-frontend/src/components/Workspace/Status/Indicator/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ const WorkspaceStatusIndicatorComponent: React.FC<Props> = ({
return (
<CheTooltip content={tooltip}>
<span
role="img"
className={styles.statusIndicator}
data-testid="workspace-status-indicator"
aria-label={
Expand Down
Loading