Conversation
fast-uri <= 3.1.0 decoded percent-encoded path separators before applying dot-segment removal in normalize() and equal(), allowing attacker-controlled URIs to bypass path-based policy checks. Add resolution pin fast-uri@^3.1.1 to force all transitive dependents to use the patched release (3.1.2). Fixes: CRW-10862 Signed-off-by: Oleksii Orel <oorel@redhat.com>
Signed-off-by: Oleksii Orel <oorel@redhat.com>
Contributor
|
Click here to review and test in web IDE: |
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1588 (linux/amd64, linux/arm64) kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1588", name: che-dashboard}]}}]" |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1588 +/- ##
==========================================
- Coverage 92.49% 92.48% -0.01%
==========================================
Files 563 563
Lines 56254 56254
Branches 4267 4266 -1
==========================================
- Hits 52030 52029 -1
- Misses 4174 4175 +1
Partials 50 50 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
svor
approved these changes
May 28, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: olexii4, svor The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Bumps the transitive dependency
fast-urifrom3.1.0to3.1.2to address a path traversal vulnerability.fast-uriversions<= 3.1.0decoded percent-encoded path separators (%2F) and dot segments (%2E) before applying dot-segment normalization in itsnormalize()andequal()functions. This means that an attacker-controlled URI like:would normalize to
/secret, bypassing any path-prefix policy that checked the raw string. Applications that compare or normalize untrusted URLs to enforce access control were affected.3.1.1introduced the fix;3.1.2is the latest patched release.A resolution pin
"fast-uri": "^3.1.1"is added to the rootpackage.jsonto force all transitive dependents (e.g.@fastify/ajv-compiler,fast-json-stringify,ajv) to use the patched version.Screenshot/screencast of this PR
N/A — dependency bump only.
What issues does this PR fix or reference?
fixes https://redhat.atlassian.net/browse/CRW-10862