Conversation
The gray meta-information text in each event card (involved object name
and 'Generated from <source>' line) used PatternFly's subtle text color
token (--pf-t--global--text--color--subtle), which produces a contrast
ratio of ~3.65:1 against the card background. This fails WCAG 1.4.3
Contrast (Minimum, Level AA), which requires 4.5:1 for standard text.
Override --pf-v6-c-content--small--Color at the CardHeader container
level to use --pf-t--global--text--color--regular, which achieves a
contrast ratio of at least 4.5:1.
Affected pages: Workspace Details > Events tab,
Start Workspace progress > Events tab.
Signed-off-by: Oleksii Orel <oorel@redhat.com>
Contributor
|
Click here to review and test in web IDE: |
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1591 (linux/amd64, linux/arm64) kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1591", name: che-dashboard}]}}]" |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1591 +/- ##
=======================================
Coverage 92.49% 92.49%
=======================================
Files 563 563
Lines 56254 56254
Branches 4267 4267
=======================================
Hits 52030 52030
Misses 4174 4174
Partials 50 50 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: olexii4, svor The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a WCAG 1.4.3 Contrast (Minimum, Level AA) violation in the Events tab on both the Workspace Details page and the Start Workspace progress page.
Fix
One CSS custom property override in
WorkspaceEvents/Item/index.module.css:No HTML structure changes — the fix is CSS-only and scoped to the event card header.
Screenshot/screencast of this PR
After: meta text at ≥ 4.5:1 — no contrast violation.
What issues does this PR fix or reference?
fixes https://redhat.atlassian.net/browse/CRW-10318
Is it tested? How?
Release Notes
Docs PR