chore(claude): add project skills and rules by olexii4 · Pull Request #1610 · eclipse-che/che-dashboard

olexii4 · 2026-06-22T15:04:29Z

What does this PR do?

Adds eight Claude Code skills for recurring che-dashboard workflows.

fix-cve-dep — upgrade a vulnerable npm dep: check ClearlyDefined for license indexing, pin in resolutions when needed, reinstall, regenerate .deps files, commit with CVE reference.
rebase-to-main — rebase a branch onto latest main, resolve the recurring .deps/ conflict patterns (take-theirs then regenerate), run license check, force-push.
fix-pr-feedback — fetch inline and general PR review comments via gh api, triage fixed vs open, apply outstanding fixes, push.
check-coverage — run coverage for changed packages only, identify uncovered code, write missing tests. Enforces thresholds (common 99%/100%, frontend 92/88/85, backend 86/80/86) before a PR is opened.
pr-description — generate a PR description from branch context, save to openspec/docs/. Requires check-coverage to pass first.
pr-test-section — write the "Is it tested? How?" section using the right template (deploy + verify, unit tests, dep upgrade, N/A) based on change type. Derived from analysis of 25+ closed PRs.
commit-message — write a human-style commit message: subject line, optional body, trailers. Includes anti-pattern table drawn from the actual commit history.
manage-resolutions — audit resolutions in package.json, identify orphans and stale pins, safely remove them one at a time with yarn install diff verification.

Screenshot/screencast of this PR

N/A — tooling/config changes only.

What issues does this PR fix or reference?

fixes eclipse-che/che#23852

Is it tested? How?

Skills are SKILL.md prose files — no executable code changed.

Release Notes

N/A

Docs PR

N/A

openshift-ci · 2026-06-22T15:04:34Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

che-bot · 2026-06-22T15:04:42Z

Click here to review and test in web IDE:

tolusha · 2026-06-22T15:12:26Z

Hi! I'm che-ai-assistant — I help with your pull requests.

Available commands:

/che-ai-assistant generate-che-doc — Generate a documentation PR based on this PR's changes
/che-ai-assistant ok-pr-review — Run a comprehensive PR review (summary, code review, deep review, impact analysis)
/che-ai-assistant help — Show this help message

tolusha · 2026-06-22T15:12:27Z

⚠️ Warning: IDE/tool configuration files detected

This PR contains changes to files in directories that are typically not intended to be committed:

.claude/CLAUDE.md
.claude/rules/che-dashboard-dev.mdc
.claude/skills/check-coverage/SKILL.md
.claude/skills/commit-message/SKILL.md
.claude/skills/fix-cve-dep/SKILL.md
.claude/skills/fix-pr-feedback/SKILL.md
.claude/skills/manage-resolutions/SKILL.md
.claude/skills/pr-description/SKILL.md
.claude/skills/pr-test-section/SKILL.md
.claude/skills/rebase-to-main/SKILL.md

Please verify these changes are intentional.

github-actions · 2026-06-22T15:20:44Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1610 (linux/amd64, linux/arm64, linux/s390x)

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1610", name: che-dashboard}]}}]"

codecov · 2026-06-22T17:05:15Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.36%. Comparing base (c5a69aa) to head (5fb2013).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1610   +/-   ##
=======================================
  Coverage   92.36%   92.36%           
=======================================
  Files         587      587           
  Lines       60484    60484           
  Branches     4688     4688           
=======================================
  Hits        55869    55869           
  Misses       4556     4556           
  Partials       59       59

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2026-06-24T14:46:38Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1610 (linux/amd64, linux/arm64, linux/s390x)

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1610", name: che-dashboard}]}}]"

github-actions · 2026-06-24T14:54:08Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1610 (linux/amd64, linux/arm64, linux/s390x)

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1610", name: che-dashboard}]}}]"

Add five Claude Code skills distilled from recurring che-dashboard development workflows: - fix-cve-dep: upgrade a vulnerable npm dep, check ClearlyDefined, pin in resolutions, regenerate .deps files, commit and push - rebase-to-main: rebase a branch onto main, resolve .deps conflicts (take-theirs + regenerate), run license check, force-push - fix-pr-feedback: fetch and triage GitHub PR review comments, fix open items, commit and push - check-coverage: run coverage for changed packages, find uncovered code, write missing tests; enforces thresholds (common 99/100, frontend 92/88/85, backend 86/80/86) before PR is opened - pr-description: generate a PR description from branch context and save to openspec/docs/ following project template (check-coverage must pass first) Update CLAUDE.md to reference the new rules file and list all skills. Update AGENTS.md to reference .claude/rules/ and document all skills. Simplify .claude/rules/che-dashboard-dev.mdc (292 → 173 lines): - Remove §2 pre-push trailer cleanup (Cursor IDE defense) - Remove §7 building local images (human how-to, not an AI rule) - Remove §8 PR descriptions (superseded by pr-description skill) - Fix §3: split pre-commit (fast) vs pre-push (full suite) - Fix §4 dep format example to match actual .deps/prod.md format - Remove duplicate --updateSnapshot and tooltip CSS sub-section Remove personal identity data from all rules and skill files: - Signed-off-by uses {AUTHOR_NAME} <{AUTHOR_EMAIL}> placeholder - quay.io/oorel/ replaced with quay.io/{YOUR_QUAY_USERNAME}/ Assisted-by: Claude Sonnet 4.6 Signed-off-by: Oleksii Orel <oorel@redhat.com>

github-actions · 2026-06-24T15:01:00Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1610 (linux/amd64, linux/arm64, linux/s390x)

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1610", name: che-dashboard}]}}]"

github-actions · 2026-06-24T15:10:16Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1610 (linux/amd64, linux/arm64, linux/s390x)

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1610", name: che-dashboard}]}}]"

github-actions · 2026-06-24T15:14:02Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1610 (linux/amd64, linux/arm64, linux/s390x)

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1610", name: che-dashboard}]}}]"

openshift-ci · 2026-06-24T15:37:09Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: olexii4, svor

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci Bot added the do-not-merge/work-in-progress label Jun 22, 2026

olexii4 changed the title ~~[wip]chore(claude): add project skills and generalize dev-conventions rules~~ [wip]chore(claude): add project skills and rules Jun 22, 2026

olexii4 changed the title ~~[wip]chore(claude): add project skills and rules~~ chore(claude): add project skills and rules Jun 22, 2026

olexii4 force-pushed the add_skills branch from 5fb2013 to 3f55fb8 Compare June 23, 2026 21:02

openshift-ci Bot added the needs-rebase label Jun 23, 2026

olexii4 force-pushed the add_skills branch 2 times, most recently from 783cd2a to 23e9a80 Compare June 24, 2026 14:32

openshift-ci Bot removed the needs-rebase label Jun 24, 2026

olexii4 marked this pull request as ready for review June 24, 2026 14:36

olexii4 requested review from akurinnoy and ibuziuk as code owners June 24, 2026 14:36

openshift-ci Bot removed the do-not-merge/work-in-progress label Jun 24, 2026

olexii4 force-pushed the add_skills branch 2 times, most recently from 5508148 to 9f828fd Compare June 24, 2026 14:46

olexii4 force-pushed the add_skills branch from 9f828fd to dba7df2 Compare June 24, 2026 14:57

olexii4 force-pushed the add_skills branch from dba7df2 to ba97e10 Compare June 24, 2026 14:59

olexii4 requested a review from svor June 24, 2026 15:16

svor approved these changes Jun 24, 2026

View reviewed changes

openshift-ci Bot assigned svor Jun 24, 2026

openshift-ci Bot added the lgtm label Jun 24, 2026

olexii4 merged commit 00bd55a into main Jun 24, 2026
17 of 18 checks passed

olexii4 deleted the add_skills branch June 24, 2026 18:09

Uh oh!

Conversation

olexii4 commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Screenshot/screencast of this PR

What issues does this PR fix or reference?

Is it tested? How?

Release Notes

Docs PR

Uh oh!

openshift-ci Bot commented Jun 22, 2026

Uh oh!

che-bot commented Jun 22, 2026

Uh oh!

tolusha commented Jun 22, 2026

Uh oh!

tolusha commented Jun 22, 2026

Uh oh!

github-actions Bot commented Jun 22, 2026

Uh oh!

codecov Bot commented Jun 22, 2026

Codecov Report

Uh oh!

github-actions Bot commented Jun 24, 2026

Uh oh!

github-actions Bot commented Jun 24, 2026

Uh oh!

github-actions Bot commented Jun 24, 2026

Uh oh!

github-actions Bot commented Jun 24, 2026

Uh oh!

github-actions Bot commented Jun 24, 2026

Uh oh!

openshift-ci Bot commented Jun 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

olexii4 commented Jun 22, 2026 •

edited

Loading