fix: install asciidoctor-pdf gem for PDF generation in CI#3139
Closed
gtrivedi88 wants to merge 1 commit into
Closed
fix: install asciidoctor-pdf gem for PDF generation in CI#3139gtrivedi88 wants to merge 1 commit into
gtrivedi88 wants to merge 1 commit into
Conversation
The @antora/pdf-extension shells out to `asciidoctor-pdf` (Ruby gem) to convert assembled AsciiDoc files to PDF. The gem was never installed in the container, causing ENOENT errors when the build tries to read the generated PDF files: FATAL (antora): ENOENT: no such file or directory, open 'build/assembler-pdf/docs/next/_exports/discover.pdf' This broke all PR checks after the Discover module was added (eclipse-che#3098). Fix: add `gem install asciidoctor-pdf` to the Containerfile. Co-authored-by: Cursor <cursoragent@cursor.com>
gtrivedi88
requested review from
a team,
deerskindoll and
mkuznyetsov
as code owners
|
⚡️ Deploying pull request preview... |
|
Click here to review and test in web IDE: |
-525C86?logo=eclipse-che&labelColor=red){kind=icon}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
asciidoctor-pdfRuby gem in the ContainerfileWhy
The
@antora/pdf-extension(installed at1.0.0-beta.14) shells out toasciidoctor-pdfto convert assembled AsciiDoc files to PDF. This Ruby gem was never installed in the container, causing all PR checks to fail with:This has been breaking all PR checks since the Discover module was added in #3098.
What changed
Containerfilegem install asciidoctor-pdfafter the Python packages stepTest plan
antora generateproduces PDF files inbuild/assembler-pdf/Made with Cursor