fix: remove @antora/pdf-extension to unblock CI#3140
Merged
Conversation
The @antora/pdf-extension requires the asciidoctor-pdf Ruby gem to convert assembled AsciiDoc to PDF. This gem was never installed in the che-docs container, so PDF generation silently failed. After the base image (quay.io/podman/stable:latest) updated, the extension started crashing with ENOENT instead of failing silently: FATAL (antora): ENOENT: no such file or directory, open 'build/assembler-pdf/docs/next/_exports/discover.pdf' This breaks all PR checks. Since PDFs are not served on the live site and the extension comment confirms it was used for "monolithic AsciiDoc files" (not actual PDFs), removing it is safe. The @antora/assembler and @antora/pdf-extension npm packages remain in the Containerfile for potential future use. Co-authored-by: Cursor <cursoragent@cursor.com>
gtrivedi88
requested review from
a team,
deerskindoll and
mkuznyetsov
as code owners
|
🎊 Navigate the preview: https://6a46170ab3b70f6d34f830b9--eclipse-che-docs-pr.netlify.app 🎊 |
|
Click here to review and test in web IDE: |
-525C86?logo=eclipse-che&labelColor=red){kind=icon}
ibuziuk
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@antora/pdf-extensionfromantora-playbook-for-development.ymlWhy
The
@antora/pdf-extensionrequiresasciidoctor-pdf(Ruby gem) to convert assembled AsciiDoc to PDF. This gem was never installed in the container. After the base image (quay.io/podman/stable:latest) updated, the extension started crashing with:This breaks all PR checks — both "Build and validate pull request" and "Build and verify container".
PDFs are not served on the live site. The extension comment confirms it was used for "monolithic AsciiDoc files", not actual PDFs. The npm packages (
@antora/assembler,@antora/pdf-extension) remain in the Containerfile for potential future use.Test plan
Made with Cursor