Skip to content

Commit f7d5a3f

Browse files
committed
fix(e2e): update Actions button locator for workspace-specific aria-label
The dashboard changed aria-label="Actions" to aria-label="Actions for {workspace name}" (CRW-10287). Update the e2e locator to match the new pattern. Assisted-by: Claude Opus 4.6 Signed-off-by: Oleksii Orel <oorel@redhat.com>
1 parent adf4048 commit f7d5a3f

3 files changed

Lines changed: 3 additions & 7 deletions

File tree

tests/e2e/.prettierignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
build
2+
.claude
23
**report
34
**results**
45
dist

tests/e2e/CODE_STYLE.md

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ Automated lint checking and code format performs with ESLint and Prettier tools
2828
### Preferable code style
2929

3030
1. Page-object and util classes
31-
3231
1. ✔ Class declaration using dependency injection (inversify library)
3332

3433
```
@@ -38,7 +37,6 @@ Automated lint checking and code format performs with ESLint and Prettier tools
3837
```
3938
4039
2. Public methods
41-
4240
- ✔ Declare public methods without "public "keyword
4341
- ✔ Add Logger.debug() inside method to log its name (with optional message)
4442
@@ -51,7 +49,6 @@ Automated lint checking and code format performs with ESLint and Prettier tools
5149
```
5250
5351
3. Locators
54-
5552
- ✔ For static locators - private static readonly fields type of By
5653
5754
```
@@ -105,7 +102,6 @@ Automated lint checking and code format performs with ESLint and Prettier tools
105102
```
106103
107104
2. Mocha framework
108-
109105
- ✔ TDD framework (`suite()`, `test()`)
110106
- ✔ Inject class instances, declare all test data inside test `suit()` function to avoid unnecessary code execution if test suit will not be run
111107
@@ -122,7 +118,6 @@ Automated lint checking and code format performs with ESLint and Prettier tools
122118
- ✔ Use test [./constants](constants) to make test flexible
123119
124120
3. Packages
125-
126121
1. Add packages as dev dependencies
127122
2. If any changes re-create package-lock.json before push
128123

tests/e2e/pageobjects/dashboard/Workspaces.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -227,12 +227,12 @@ export class Workspaces {
227227
}
228228

229229
private getActionsLocator(workspaceName: string): By {
230-
return By.xpath(`${this.getWorkspaceListItemLocator(workspaceName).value}/td/button[@aria-label='Actions']`);
230+
return By.xpath(`${this.getWorkspaceListItemLocator(workspaceName).value}/td/button[@aria-label='Actions for ${workspaceName}']`);
231231
}
232232

233233
/* private getExpandedActionsLocator(workspaceName: string): By {
234234
return By.xpath(
235-
`${this.getWorkspaceListItemLocator(workspaceName).value}//button[@aria-label='Actions' and @aria-expanded='true']`
235+
`${this.getWorkspaceListItemLocator(workspaceName).value}//button[@aria-label='Actions for ${workspaceName}' and @aria-expanded='true']`
236236
);
237237
}*/
238238

0 commit comments

Comments
 (0)