Skip to content

Update PHP to 7.2#11440

Closed
filips123 wants to merge 1 commit into
eclipse-che:masterfrom
filips123:patch-1
Closed

Update PHP to 7.2#11440
filips123 wants to merge 1 commit into
eclipse-che:masterfrom
filips123:patch-1

Conversation

@filips123

Copy link
Copy Markdown

It updates PHP from 7.0 to 7.2 in PHP stack description. See eclipse-che/che-dockerfiles#214.

@riuvshin

riuvshin commented Oct 2, 2018

Copy link
Copy Markdown
Contributor

Can one of the admins verify this patch?

@filips123 filips123 requested a review from ashumilova as a code owner October 2, 2018 14:34
@riuvshin

riuvshin commented Oct 2, 2018

Copy link
Copy Markdown
Contributor

Can one of the admins verify this patch?

1 similar comment
@riuvshin

riuvshin commented Oct 2, 2018

Copy link
Copy Markdown
Contributor

Can one of the admins verify this patch?

@benoitf benoitf added kind/enhancement A feature request - must adhere to the feature request template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Oct 2, 2018
@musienko-maxim

Copy link
Copy Markdown
Contributor

Can one of the admins verify this PR?

@monaka monaka added the status/blocked Issue that can’t be moved forward. Must include a comment on the reason for the blockage. label May 6, 2019
@monaka

monaka commented May 6, 2019

Copy link
Copy Markdown
Member

@musienko-maxim @filips123 This PR is blocked by eclipse-che/che-dockerfiles#214. And must pass the ECA check.

@monaka

monaka commented Jul 17, 2019

Copy link
Copy Markdown
Member

@filips123 I think this PR is outdated. Just closing, or re-targeting to Che-6.x ?

@filips123

Copy link
Copy Markdown
Author

@monaka How should I re-target it to Che 6?

@monaka

monaka commented Jul 25, 2019

Copy link
Copy Markdown
Member

This PR is obsolete by #13788. I close it.
@filips123 please make new PR to the 6.19.x branch if you want to request merging this.

@monaka monaka closed this Jul 25, 2019
@monaka

monaka commented Jul 25, 2019

Copy link
Copy Markdown
Member

@filips123 How to re-target is like this.

  1. create new branch from 6.19.x branch on your fork.
  2. cherry-pick your patch in this PR to new branch.
  3. push your branch created on step 1.
  4. create new PR and set the target branch 6.19.x (not the master branch).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement A feature request - must adhere to the feature request template. status/blocked Issue that can’t be moved forward. Must include a comment on the reason for the blockage. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants