fix (tests) : update userstory path to specs/dashboard-samples (#23514)#23515
Merged
dmytro-ndp merged 1 commit intoeclipse-che:mainfrom Aug 6, 2025
Merged
Conversation
…se-che#23514) The test script was previously checking for user stories under `specs/devfiles`, which no longer exists or contains relevant test specs. This commit updates the `checkUserstoryName` function to look in `specs/dashboard-samples`, where the current user story specs (e.g., `*.spec.ts`) are now located. This resolves issues where valid USERSTORY values were incorrectly reported as missing. Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia
requested review from
dmytro-ndp and
musienko-maxim
as code owners
Contributor
|
@rohanKanojia : hello, Do you happen to have successful test run logs to share? |
Contributor
Author
|
@dmytro-ndp : Hello, Please find the complete logs attached: Output after running |
Contributor
|
Thanks for sharing, @rohanKanojia Well done! |
dmytro-ndp
approved these changes
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The test script was previously checking for user stories under
specs/devfiles, which no longer exists or contains relevant test specs. This commit updates thecheckUserstoryNamefunction to look inspecs/dashboard-samples, where the current user story specs (e.g.,*.spec.ts) are now located.This resolves issues where valid USERSTORY values were incorrectly reported as missing.
Screenshot/screencast of this PR
This PR is fixing Che Happy Path E2E test. It is currently failing with this error:
Run
./launch.shintests/devworkspace-happy-path, you'd see this error:With these changes, I'm able to see Happy Path Test getting fully executed and passing. Here are logs:
What issues does this PR fix or reference?
Fix #23514
Related to devfile/devworkspace-operator#1474
How to test this PR?
cd tests/e2edocker build -t ${REGISTRY}/${USER}/che-e2e:next -f build/dockerfiles/Dockerfile .tests/devworkspace-happy-path/start-happypath-tests.shto use this custom imagecd tests/devworkspace-happy-path./launch.shYou should be able to see all the specs getting tested and logged in test output.
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.