Skip to content

Fix a null reference exception in parseSeparationColumn#2997

Merged
eselmeister merged 1 commit into
eclipse-chemclipse:developfrom
Mailaender:column-chrom-ref-null
Jul 17, 2026
Merged

Fix a null reference exception in parseSeparationColumn#2997
eselmeister merged 1 commit into
eclipse-chemclipse:developfrom
Mailaender:column-chrom-ref-null

Conversation

@Mailaender

Copy link
Copy Markdown
Contributor
java.lang.NullPointerException: Cannot invoke "org.eclipse.chemclipse.model.core.IChromatogram.isParseSeparationColumnEnabled()" because "chromatogramReference" is null
	at org.eclipse.chemclipse.model.support.ChromatogramColumnSupport.parseSeparationColumn(ChromatogramColumnSupport.java:53)
	at org.eclipse.chemclipse.model.support.ChromatogramColumnSupport.parseSeparationColumn(ChromatogramColumnSupport.java:34)
	at org.eclipse.chemclipse.converter.chromatogram.AbstractChromatogramConverter.postProcessChromatogram(AbstractChromatogramConverter.java:269)
	at org.eclipse.chemclipse.converter.chromatogram.AbstractChromatogramConverter.convert(AbstractChromatogramConverter.java:153)
	at org.eclipse.chemclipse.ux.extension.xxd.ui.internal.runnables.ChromatogramImportRunnable.run(ChromatogramImportRunnable.java:103)
	at org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:123)

@Mailaender
Mailaender force-pushed the column-chrom-ref-null branch from 02a1a4f to 3cfdd4a Compare July 17, 2026 10:39
@eselmeister

Copy link
Copy Markdown
Contributor

That's strange. A chromatogram reference shouldn't be null at all. Normally, it should be checked when adding a reference:

if(reference != null) {
	chromatogram.addReferencedChromatogram(reference);
}

@eselmeister
eselmeister merged commit 5997e01 into eclipse-chemclipse:develop Jul 17, 2026
4 checks passed
@Mailaender
Mailaender deleted the column-chrom-ref-null branch July 17, 2026 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants