Skip to content

Remove workarounds in Data Explorer icons #2998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eselmeister merged 1 commit into from
Jul 17, 2026
Merged

Remove workarounds in Data Explorer icons #2998

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 1 addition & 18 deletions ...ion.ui/src/org/eclipse/chemclipse/ux/extension/ui/provider/DataExplorerLabelProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@
import org.eclipse.jface.resource.LocalResourceManager;
import org.eclipse.jface.resource.ResourceManager;
import org.eclipse.jface.viewers.ColumnLabelProvider;
import org.eclipse.jface.viewers.ViewerCell;
import org.eclipse.swt.graphics.Image;
import org.eclipse.ui.navigator.IDescriptionProvider;

Expand Down Expand Up @@ -74,23 +73,7 @@ public String getDescription(Object element) {
}

@Override
public void update(ViewerCell cell) {

Object element = cell.getElement();
cell.setText(getText(element));
Image image = getIcon(element);
// https://github.com/eclipse-platform/eclipse.platform.swt/issues/678
cell.getItem().getDisplay().asyncExec(() -> {
if(!cell.getItem().isDisposed()) {
cell.setImage(image);
}
});
cell.setBackground(getBackground(element));
cell.setForeground(getForeground(element));
cell.setFont(getFont(element));
}

public Image getIcon(Object element) {
public Image getImage(Object element) {

if(element instanceof File file) {
ImageDescriptor descriptor = null;
Expand Down