Extract CI failure summary into reusable workflow#2625
Closed
FlorianReimold wants to merge 21 commits into
Closed
Conversation
…pdate PR number handling
Test reusable CI failure summary workflow integration
Extract CI failure summary into reusable workflow
Contributor
CI Test Results
❌ ubuntu-22.04-arm
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| EXPECT_EQ(false, eCAL::Ok()); | ||
| } | ||
|
|
||
| TEST(core_cpp_core, IntentionalFailure_One) |
Contributor
There was a problem hiding this comment.
warning: all parameters should be named in a function [readability-named-parameter]
Suggested change
| TEST(core_cpp_core, IntentionalFailure_One) | |
| TEST(core_cpp_core /*unused*/, IntentionalFailure_One /*unused*/) |
| EXPECT_EQ(1, 2) << "Intentional CI failure #1 for summary validation"; | ||
| } | ||
|
|
||
| TEST(core_cpp_core, IntentionalFailure_Two) |
Contributor
There was a problem hiding this comment.
warning: all parameters should be named in a function [readability-named-parameter]
Suggested change
| TEST(core_cpp_core, IntentionalFailure_Two) | |
| TEST(core_cpp_core /*unused*/, IntentionalFailure_Two /*unused*/) |
| EXPECT_TRUE(false) << "Intentional CI failure #2 for summary validation"; | ||
| } | ||
|
|
||
| TEST(core_cpp_core, IntentionalFailure_Three) |
Contributor
There was a problem hiding this comment.
warning: all parameters should be named in a function [readability-named-parameter]
Suggested change
| TEST(core_cpp_core, IntentionalFailure_Three) | |
| TEST(core_cpp_core /*unused*/, IntentionalFailure_Three /*unused*/) |
KerstinKeller
left a comment
KerstinKeller
left a comment
Contributor
There was a problem hiding this comment.
In addition to cleaning up the failed test cases we for sure need to reactivate the workflows properly.
| branches: | ||
| - master | ||
| on: | ||
| workflow_dispatch: |
Contributor
There was a problem hiding this comment.
This means that GH actions for macos will run only on demand. Do we want this?
| pull_request: | ||
| branches: | ||
| - master | ||
| workflow_dispatch: |
Contributor
There was a problem hiding this comment.
We definately don't want this here
| on: | ||
| push: | ||
| pull_request: | ||
| workflow_dispatch: |
Contributor
|
Will be handled #2632 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.