Transfer of execution data through socket should use buffered stream#130
Draft
Godin wants to merge 1 commit into
Draft
Transfer of execution data through socket should use buffered stream#130Godin wants to merge 1 commit into
Godin wants to merge 1 commit into
Conversation
3 tasks
Godin
commented
Mar 31, 2026
Comment on lines
46
to
47
| final RemoteControlWriter writer = new RemoteControlWriter( | ||
| socket.getOutputStream()); |
Member
Author
There was a problem hiding this comment.
Following the same logic as in jacoco/jacoco#2089 (comment)
Suggested change
| final RemoteControlWriter writer = new RemoteControlWriter( | |
| socket.getOutputStream()); | |
| final RemoteControlWriter writer = new RemoteControlWriter( | |
| // BufferedOutputStream will not improve performance here | |
| // while will add memory overhead because commands are short | |
| socket.getOutputStream()); |
| @@ -109,7 +110,7 @@ protected IStatus run(IProgressMonitor monitor) { | |||
| final Socket socket = serverSocket.accept(); | |||
| writer = new RemoteControlWriter(socket.getOutputStream()); | |||
Member
Author
There was a problem hiding this comment.
Following the same logic as in jacoco/jacoco#2089 (comment)
Suggested change
| writer = new RemoteControlWriter(socket.getOutputStream()); | |
| writer = new RemoteControlWriter( | |
| // BufferedOutputStream will not improve performance here | |
| // while will add memory overhead because commands are short | |
| socket.getOutputStream()); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See jacoco/jacoco#2089