Skip to content

Transfer of execution data through socket should use buffered stream #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Godin wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Transfer of execution data through socket should use buffered stream #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
243cbd6
(WIP) fix
Godin Mar 26, 2026
9b72da3
(WIP) apply suggestions from code review
Godin May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion org.eclipse.eclemma.core/src/org/eclipse/eclemma/core/AgentExecutionDataSource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
******************************************************************************/
package org.eclipse.eclemma.core;

import java.io.BufferedInputStream;
import java.io.IOException;
import java.net.Socket;

Expand Down Expand Up @@ -43,9 +44,11 @@ public void accept(IExecutionDataVisitor executionDataVisitor,
try {
final Socket socket = new Socket(address, port);
final RemoteControlWriter writer = new RemoteControlWriter(
// BufferedOutputStream will not improve performance here
// while will add memory overhead because commands are short
socket.getOutputStream());
Comment thread
Godin marked this conversation as resolved.
final RemoteControlReader reader = new RemoteControlReader(
socket.getInputStream());
new BufferedInputStream(socket.getInputStream()));
reader.setExecutionDataVisitor(executionDataVisitor);
reader.setSessionInfoVisitor(sessionInfoVisitor);
writer.visitDumpCommand(true, reset);
Expand Down
8 changes: 6 additions & 2 deletions org.eclipse.eclemma.core/src/org/eclipse/eclemma/internal/core/launching/AgentServer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
******************************************************************************/
package org.eclipse.eclemma.internal.core.launching;

import java.io.BufferedInputStream;
import java.io.IOException;
import java.net.InetAddress;
import java.net.ServerSocket;
Expand Down Expand Up @@ -107,9 +108,12 @@ public int getPort() {
protected IStatus run(IProgressMonitor monitor) {
try {
final Socket socket = serverSocket.accept();
writer = new RemoteControlWriter(socket.getOutputStream());
writer = new RemoteControlWriter(
// BufferedOutputStream will not improve performance here
// while will add memory overhead because commands are short
socket.getOutputStream());
final RemoteControlReader reader = new RemoteControlReader(
socket.getInputStream());
new BufferedInputStream(socket.getInputStream()));
while (true) {
final MemoryExecutionDataSource memory = new MemoryExecutionDataSource();
memory.readFrom(reader);
Expand Down