feat: add dataspace profile management vertical#5861
Merged
wolf4ood merged 2 commits intoJul 2, 2026
Conversation
wolf4ood
force-pushed
the
feat/5746_dataspace_profile_mgmt
branch
from
9158bf6 to
3a7bd27
Compare
wolf4ood
force-pushed
the
feat/5746_dataspace_profile_mgmt
branch
from
3a7bd27 to
f02cd87
Compare
ndr-brt
approved these changes
Jul 2, 2026
|
|
||
| @Override | ||
| public @NotNull ServiceResult<DataspaceProfile> deleteById(String name) { | ||
| return transactionContext.execute(() -> ServiceResult.from(store.delete(name))); |
Member
There was a problem hiding this comment.
given that we register the context on create, we should "unregister` it on deletion
Contributor
Author
There was a problem hiding this comment.
We should but that opens more work for this PR. I left it out since it's not a frequent operation and potentially dangerous operation 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Add vertical for add dataspace profile management
The DataspaceProfile works together with the current DataspaceProfileContextRegistry.
It provides the persistence for the profiles available in the connector dynamically and it seeds the DataspaceProfileContextRegistry for runtime usage
Why it does that
Briefly state why the change was necessary.
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Who will sponsor this feature?
Please @-mention the committer that will sponsor your feature.
Linked Issue(s)
Closes #5746
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.