refactor: remove control-plane core modules from federated-catalog#5864
Open
ndr-brt wants to merge 1 commit into
Open
refactor: remove control-plane core modules from federated-catalog#5864ndr-brt wants to merge 1 commit into
ndr-brt wants to merge 1 commit into
Conversation
ndr-brt
force-pushed
the
5863-remove-control-plane-from-fc
branch
5 times, most recently
from
a7a2597 to
5df729d
Compare
ndr-brt
force-pushed
the
5863-remove-control-plane-from-fc
branch
from
5df729d to
78285cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Remove control-plane core modules from federated-catalog.
In order to achieve that I had to pull up
DataspaceProfileContextRegistryImplregistration andDiscoveryclasses inconnector-core, that's a sort of abstract control-plane/federated-catalog (likely we could call itdataspace-agent, to follow the DSP nomenclature)Why it does that
Briefly state why the change was necessary.
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Who will sponsor this feature?
Please @-mention the committer that will sponsor your feature.
Linked Issue(s)
Closes #5863
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.