Skip to content

fix(config): fix policy-enforcement-consumer config#401

Merged
ndr-brt merged 1 commit into
eclipse-edc:mainfrom
AIMENandresperez:fix/policy-config
Apr 22, 2025
Merged

fix(config): fix policy-enforcement-consumer config#401
ndr-brt merged 1 commit into
eclipse-edc:mainfrom
AIMENandresperez:fix/policy-config

Conversation

@AIMENandresperez
Copy link
Copy Markdown
Contributor

What this PR changes/adds

This PR removes the trailing backslash from the web.http.protocol.path property in config.properties, changing it from /protocol\ to /protocol.

Why it does that

The trailing backslash was likely unintentional or could cause misinterpretation of the path. Removing it ensures the property value is properly interpreted and aligns with expected URL path formatting.

Further notes

No other areas of code were affected. This is a minor configuration fix.

Who will sponsor this feature?

Please @-mention the committer that will sponsor your feature.

Linked Issue(s)

Closes #396

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'We are always happy to welcome new contributors ❤️ To make things easier for everyone, please - make sure to follow our contribution guidelines, - check if you have already signed the ECA, and - relate this pull request to an existing issue or discussion.'

Copy link
Copy Markdown
Member

@ndr-brt ndr-brt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks.
you need to sign the ECA to have this merged:
https://www.eclipse.org/projects/handbook/#contributing-eca

@ndr-brt ndr-brt added the bug Something isn't working label Apr 22, 2025
@AIMENandresperez
Copy link
Copy Markdown
Contributor Author

thanks. you need to sign the ECA to have this merged: https://www.eclipse.org/projects/handbook/#contributing-eca

I’m not sure what happened, but I had already signed the agreement.

image

I can’t find the ECA Validation Tool.

Copy link
Copy Markdown
Member

@ndr-brt ndr-brt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now it works! LGTM

@ndr-brt ndr-brt merged commit c82ddf2 into eclipse-edc:main Apr 22, 2025
9 of 10 checks passed
@AIMENandresperez AIMENandresperez deleted the fix/policy-config branch April 22, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Contract Negotiation Stuck in REQUESTED State in Policy Enforcement sample

2 participants