chore: update README for basic-01-basic-connector#405
Merged
mspiekermann merged 1 commit intoeclipse-edc:mainfrom Apr 25, 2025
Merged
chore: update README for basic-01-basic-connector#405mspiekermann merged 1 commit intoeclipse-edc:mainfrom
mspiekermann merged 1 commit intoeclipse-edc:mainfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
'We are always happy to welcome new contributors ❤️ To make things easier for everyone, please - make sure to follow our contribution guidelines, - check if you have already signed the ECA, and - relate this pull request to an existing issue or discussion.'
ronjaquensel
approved these changes
Apr 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
The PR changes the README of the basic-01-basic-connector sample to correct the statement about the dependencies loaded via the grade build file.
Further it sets the log level to DEBUG to achieve the expected output with
--log-level=DEBUGWhy it does that
Update the sample description to meet the current version and requirement through the change in log-level handling.