8.0.0

[jtommy]

Upgrade to GlassFish 8.0.0 + fix generic PATH_GF_HOME handling

[dmatej]

I don't like two things:

• That now we would have .../glassfish/glassfish/... in the path
• More steps

But I like that it is universal. What do you think, @OndroMih ?

I did not notice this PR before I finished my own in #35 where I resolved it in another way. Now I doubt what solution is better :-)

[dmatej]

@pzygielo What do you think?

[jtommy]

I don't like two things:

• That now we would have .../glassfish/glassfish/... in the path
• More steps

Why .../glassfish/glassfish/...? The script copies the content of unzipped archive to the current /opt/glassfish.

@dmatej anyway no problem, you can go ahead with your PR :)

[OndroMih]

I think the name of the GlassFish installation doesn't matter very much. It's stored in the PATH_GF_HOME env variable and the image and scripts should use the env variable instead of the hardcoded path.

However, it would be good to avoid setting glassfish7 or glassfish8 as an additional system property. Then to build gf7 images later we would need to set it to glassfish7 on command line.

Maybe let's merge this PR and if you have any additional changes in your PR, @dmatej , you can rebase on top of this one.

[dmatej]

Why .../glassfish/glassfish/...? The script copies the content of unzipped archive to the current /opt/glassfish.

Because inside the zip the root directory is glassfish8 and under it is glassfish subdirectory, since GlassFish 3 if I remember well.

ll glassfish8
total 32
drwxr-xr-x  7 dmatej dmatej 4096 Feb  4 18:29 ./
drwxrwxr-x  6 dmatej dmatej 4096 Mar  2 11:30 ../
drwxr-xr-x  2 dmatej dmatej 4096 Feb  4 18:29 bin/
drwxr-xr-x 11 dmatej dmatej 4096 Feb  4 18:29 glassfish/
drwxr-xr-x  4 dmatej dmatej 4096 Feb  4 18:29 javadb/
drwxr-xr-x  2 dmatej dmatej 4096 Feb  4 18:29 META-INF/
drwxr-xr-x  8 dmatej dmatej 4096 Feb  4 18:29 mq/
-rw-r-----  1 dmatej dmatej 2841 Feb  4 18:29 README.txt

However, it would be good to avoid setting glassfish7 or glassfish8 as an additional system property. Then to build gf7 images later we would need to set it to glassfish7 on command line.

Maybe we could use just /opt/gf as the default PATH_GF_HOME. I also remember the confusion on some systems which were printing just the current dir name, and we always had to use pwd again and again to find out where we are.

[OndroMih]

OK. I would like something more descriptive than just /opt/gf but it doesn't really matter. It should be referred to using the env var.

[dmatej]

Ok, lets move on