Skip to content

Fix flaky 2#5775

Merged
senivam merged 3 commits intoeclipse-ee4j:2.xfrom
mumbler6:fix-flaky-2
Oct 22, 2024
Merged

Fix flaky 2#5775
senivam merged 3 commits intoeclipse-ee4j:2.xfrom
mumbler6:fix-flaky-2

Conversation

@mumbler6
Copy link
Copy Markdown
Contributor

Duplicate flaky test fixes same as this PR: #5764

I found two additional instances of the testDisposeComposedObjectWithPerLookupFields() test which sometimes fail under non-deterministic behavior. I used the same fix as the one in the PR above, using a HashSet comparison to check the strings within the ComposedObject.

You can reproduce this error using the https://github.com/TestingResearchIllinois/NonDex tool, which explores and reports errors in different behaviors of under-determined Java APIs.

To reproduce this problem, you can run the test with NonDex using these commands after building:

# First Test
mvn -pl inject/cdi2-se edu.illinois:nondex-maven-plugin:2.1.7:nondex -Dtest=org.glassfish.jersey.inject.cdi.se.DisposableSupplierTest#testDisposeComposedObjectWithPerLookupFields
# Second Test
mvn -pl inject/hk2 edu.illinois:nondex-maven-plugin:2.1.7:nondex -Dtest=org.glassfish.jersey.inject.hk2.DisposableSupplierTest#testDisposeComposedObjectWithPerLookupFields

Here are screenshots of the output produced by NonDex before and after the fix for the first test case:

image
image

Please let me know if you want to discuss these changes.

@senivam senivam merged commit c2e1271 into eclipse-ee4j:2.x Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants