Code cleanup - @Override, serialization, @Deprecated annotations#294
Open
dmatej wants to merge 1 commit intoeclipse-ee4j:masterfrom
Open
Code cleanup - @Override, serialization, @Deprecated annotations#294dmatej wants to merge 1 commit intoeclipse-ee4j:masterfrom
dmatej wants to merge 1 commit intoeclipse-ee4j:masterfrom
Conversation
- In previous PRs I have noticed that some overrides are bit surprising which sometimes lead to mistakes. Also refactoring is safer when compiler screams when I remove/add something with unexpected consequences. - Added @OverRide annotations - Added missing serialVersionUID numbers - Added missing @deprecated annotations - Removed redundant modifiers - Removed redundant classcasts - Variable declarations of local variables moved to their first usage. Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It would be probably better to merge this before #293