Cannot find module '@eclipse-emfcloud/sprotty-ecore/lib/action-definitions'

[hsd-dev]

Following this discussion, I am trying to get a property-view running for my GLSP diagrams based on Ecore models (some discussion here: eclipse-glsp/glsp#684 (comment)). To get the semantic URI of the selected element, I am following EcoreGlspSelectionDataService. As here, I have added 0.2.0 version of @eclipse-emfcloud/sprotty-ecore in my package.json. But I get an error

src/browser/diagram/theia-glsp-selection-forwarder.ts(20,8): error TS2307: Cannot find module '@eclipse-emfcloud/sprotty-ecore/lib/action-definitions' or its corresponding type declarations.

[ndoschek]

Hi @ipa-hsd!
Thank you for your interest in the ecore-editor and property view!
Currently, the @eclipse-emfcloud/sprotty-ecore package is not published via npm.
I would suggest to implement your own GlspSelectionDataService in your editor application. If there arise any issues, do not hesitate to come back to this discussion!

BR, Nina

PS: Please note that the @eclipse-emfcloud/ecore-glsp repository contains a demonstrator for showing an editor for Ecore models. Thus, we only focus on what’s relevant for the demonstration under a controlled environment. If you are interested in transforming this demonstrator into an adoptable state, e.g. by funding the development work or working on it yourself, please let us know!

[sgraband]

For your use case the ActionDispatcher of the widget should be enough. You can easily get this from the DiagramWidget https://github.com/eclipse/sprotty-theia/blob/efd153a410267d81af555e70c219e9efa3e3b197/src/theia/diagram-widget.ts#L68. Your GLSP widget likely either extends DiagramWidget or GLSPDiagramWidget so that method should be accessible once you get the widget.

The widget you can get with something similar to this.

Hope this helps

[hsd-dev]

wow thank you so much @sgraband and @ndoschek! This worked for me:

const widget = this.shell.currentWidget as DiagramWidget;
widget.actionDispatcher.request(new RequestModelElementAction(selectionData.semanticUri));

Have a nice weekend! <3

[hsd-dev]

@sgraband sorry to reopen this issue, but I am stuck at this problem. The action handlers are working well now, but the property view is not rendered properly. The response of the RequestModelElementAction is a string

{"name":"NewLink0","id":"95e0cf3b-5e34-4f5d-9a4d-b6a21c6b9af0"}

Please note that the function signature of providePropertyData is

async providePropertyData(selection: string | undefined): Promise<string | undefined>

In this discussion is it mentioned:
"But as JsonForms is capable of generating the type schema and UI schema itself, based on the given JSON object (in our case the property object). So to start off, we can return undefined and let JsonForms generate the schemas temporarily."

So at the moment I return undefined from getSchema and getUiSchema functions. And my widget provider is basic

@injectable()
export class EcoreGlspPropertyViewWidgetProvider extends JsonFormsPropertyViewWidgetProvider {

    canHandle(selection: Record<string, unknown> | undefined): number {
        return isGlspSelection(selection) ? 100 : 0;
    }

}

But the view that is rendered looks like this

[sgraband]

Hey @ipa-hsd,

JsonForms expects a JSONObject and not a string as its data. You could change this by using for example JSON.parse(<your string>) . When you pass the Object instead of the string to JsonForms it should work. Hope this helps.

[hsd-dev]

I thought so, but I was facing this problem. I changed it to any and now it works. Thanks for saving the day!