Skip to content

Commit 69e1a7b

Browse files
authored
Fix small issues (#22)
- Export missing package org.eclipse.emfcloud.modelserver.glsp.actions - Bind EMSModelState in EMSGLSPModule - EMSRefreshModelActionHandler should extend EMSBasicActionHandler - Update dependencies to Model Server and GLSP Server
1 parent e017d13 commit 69e1a7b

6 files changed

Lines changed: 24 additions & 11 deletions

File tree

plugins/org.eclipse.emfcloud.modelserver.glsp.integration/META-INF/MANIFEST.MF

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ Require-Bundle: org.eclipse.glsp.server,
2222
org.eclipse.emfcloud.modelserver.glsp.notation.commands
2323
Bundle-ClassPath: .
2424
Export-Package: org.eclipse.emfcloud.modelserver.glsp,
25+
org.eclipse.emfcloud.modelserver.glsp.actions,
2526
org.eclipse.emfcloud.modelserver.glsp.actions.handlers,
2627
org.eclipse.emfcloud.modelserver.glsp.client,
2728
org.eclipse.emfcloud.modelserver.glsp.layout,

plugins/org.eclipse.emfcloud.modelserver.glsp.integration/src/org/eclipse/emfcloud/modelserver/glsp/EMSGLSPModule.java

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,16 +12,18 @@
1212

1313
import org.eclipse.emfcloud.modelserver.glsp.actions.handlers.EMSOperationActionHandler;
1414
import org.eclipse.emfcloud.modelserver.glsp.actions.handlers.EMSRedoActionHandler;
15+
import org.eclipse.emfcloud.modelserver.glsp.actions.handlers.EMSRefreshModelActionHandler;
1516
import org.eclipse.emfcloud.modelserver.glsp.actions.handlers.EMSSaveModelActionHandler;
1617
import org.eclipse.emfcloud.modelserver.glsp.actions.handlers.EMSUndoActionHandler;
17-
import org.eclipse.emfcloud.modelserver.glsp.actions.handlers.EMSRefreshModelActionHandler;
1818
import org.eclipse.emfcloud.modelserver.glsp.layout.EMSLayoutEngine;
19+
import org.eclipse.emfcloud.modelserver.glsp.model.EMSModelState;
1920
import org.eclipse.glsp.server.actions.ActionHandler;
2021
import org.eclipse.glsp.server.actions.SaveModelActionHandler;
2122
import org.eclipse.glsp.server.di.GModelJsonDiagramModule;
2223
import org.eclipse.glsp.server.di.MultiBinding;
2324
import org.eclipse.glsp.server.features.undoredo.UndoRedoActionHandler;
2425
import org.eclipse.glsp.server.layout.LayoutEngine;
26+
import org.eclipse.glsp.server.model.GModelState;
2527
import org.eclipse.glsp.server.operations.OperationActionHandler;
2628

2729
public abstract class EMSGLSPModule extends GModelJsonDiagramModule {
@@ -47,4 +49,9 @@ protected Class<? extends LayoutEngine> bindLayoutEngine() {
4749
return EMSLayoutEngine.class;
4850
}
4951

52+
@Override
53+
protected Class<? extends GModelState> bindGModelState() {
54+
return EMSModelState.class;
55+
}
56+
5057
}

plugins/org.eclipse.emfcloud.modelserver.glsp.integration/src/org/eclipse/emfcloud/modelserver/glsp/actions/handlers/EMSRefreshModelActionHandler.java

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@
1212

1313
import java.util.List;
1414

15+
import org.eclipse.emfcloud.modelserver.glsp.EMSModelServerAccess;
1516
import org.eclipse.emfcloud.modelserver.glsp.actions.EMSRefreshModelAction;
1617
import org.eclipse.emfcloud.modelserver.glsp.model.EMSModelState;
17-
import org.eclipse.glsp.server.actions.AbstractActionHandler;
1818
import org.eclipse.glsp.server.actions.Action;
1919
import org.eclipse.glsp.server.features.core.model.ModelSubmissionHandler;
2020

@@ -23,16 +23,15 @@
2323
/**
2424
* Handles model updates with an ActionHandler, to make sure we're in a thread-safe context.
2525
*/
26-
public class EMSRefreshModelActionHandler extends AbstractActionHandler<EMSRefreshModelAction> {
26+
public class EMSRefreshModelActionHandler
27+
extends EMSBasicActionHandler<EMSRefreshModelAction, EMSModelState, EMSModelServerAccess> {
2728

2829
@Inject
2930
protected ModelSubmissionHandler submissionHandler;
3031

31-
@Inject
32-
protected EMSModelState modelState;
33-
3432
@Override
35-
protected List<Action> executeAction(final EMSRefreshModelAction actualAction) {
33+
public List<Action> executeAction(final EMSRefreshModelAction action, final EMSModelState modelState,
34+
final EMSModelServerAccess modelServerAccess) {
3635
// reload models
3736
modelState.loadSourceModels();
3837
// refresh GModelRoot

plugins/org.eclipse.emfcloud.modelserver.glsp.integration/src/org/eclipse/emfcloud/modelserver/glsp/notation/integration/EMSNotationGLSPModule.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
import org.eclipse.emfcloud.modelserver.glsp.operations.handlers.EMSChangeBoundsOperationHandler;
1515
import org.eclipse.emfcloud.modelserver.glsp.operations.handlers.EMSLayoutOperationHandler;
1616
import org.eclipse.glsp.server.di.MultiBinding;
17+
import org.eclipse.glsp.server.model.GModelState;
1718
import org.eclipse.glsp.server.operations.OperationHandler;
1819
import org.eclipse.glsp.server.operations.gmodel.ChangeBoundsOperationHandler;
1920
import org.eclipse.glsp.server.operations.gmodel.LayoutOperationHandler;
@@ -27,4 +28,9 @@ protected void configureOperationHandlers(final MultiBinding<OperationHandler> b
2728
binding.rebind(LayoutOperationHandler.class, EMSLayoutOperationHandler.class);
2829
}
2930

31+
@Override
32+
protected Class<? extends GModelState> bindGModelState() {
33+
return EMSNotationModelState.class;
34+
}
35+
3036
}

releng/org.eclipse.emfcloud.modelserver.glsp.releng.target/targetdefinition.target

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
22
<?pde?>
33
<!-- generated with https://github.com/eclipse-cbi/targetplatform-dsl -->
4-
<target name="EMF.cloud Model Server GLSP Integration Targetplatform" sequenceNumber="1637573334">
4+
<target name="EMF.cloud Model Server GLSP Integration Targetplatform" sequenceNumber="1637673776">
55
<locations>
66
<location includeMode="planner" includeAllPlatforms="false" includeSource="true" includeConfigurePhase="false" type="InstallableUnit">
77
<unit id="org.eclipse.glsp.feature.feature.group" version="0.9.0.202111041528"/>
@@ -10,8 +10,8 @@
1010
<repository location="https://download.eclipse.org/glsp/server/p2/nightly/0.9/0.9.0.202111041528/"/>
1111
</location>
1212
<location includeMode="planner" includeAllPlatforms="false" includeSource="true" includeConfigurePhase="false" type="InstallableUnit">
13-
<unit id="org.eclipse.emfcloud.modelserver.feature.feature.group" version="0.7.0.202110081257"/>
14-
<repository location="https://download.eclipse.org/emfcloud/modelserver/p2/nightly/0.7/0.7.0.202110081257/"/>
13+
<unit id="org.eclipse.emfcloud.modelserver.feature.feature.group" version="0.7.0.202111221314"/>
14+
<repository location="https://download.eclipse.org/emfcloud/modelserver/p2/nightly/0.7/0.7.0.202111221314/"/>
1515
</location>
1616
<location includeMode="planner" includeAllPlatforms="false" includeSource="true" includeConfigurePhase="false" type="InstallableUnit">
1717
<unit id="org.eclipse.equinox.executable.feature.group" version="3.8.1200.v20210527-0259"/>

releng/org.eclipse.emfcloud.modelserver.glsp.releng.target/targetdefinition.tpd

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ location "https://download.eclipse.org/glsp/server/p2/nightly/0.9/0.9.0.20211104
66
org.eclipse.glsp.graph [0.9.0,1.0.0)
77
}
88

9-
location "https://download.eclipse.org/emfcloud/modelserver/p2/nightly/0.7/0.7.0.202110081257/" {
9+
location "https://download.eclipse.org/emfcloud/modelserver/p2/nightly/0.7/0.7.0.202111221314/" {
1010
org.eclipse.emfcloud.modelserver.feature.feature.group [0.7.0,1.0.0)
1111
}
1212

0 commit comments

Comments
 (0)