Skip to content

Clean Code for bundles/org.eclipse.equinox.console#1078

Merged
laeubi merged 1 commit into
masterfrom
clean-code/bundles/org.eclipse.equinox.console
Jul 22, 2025
Merged

Clean Code for bundles/org.eclipse.equinox.console#1078
laeubi merged 1 commit into
masterfrom
clean-code/bundles/org.eclipse.equinox.console

Conversation

@eclipse-equinox-bot
Copy link
Copy Markdown
Contributor

The following cleanups were applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Remove trailing white spaces on all lines
  • Remove unnecessary array creation for varargs
  • Remove unnecessary suppress warning tokens
  • Remove unused imports
  • Remove unused private constructors
  • Remove unused private fields
  • Remove unused private methods
  • Remove unused private types
  • Replace deprecated calls with inlined content where possible
  • Use pattern matching for instanceof

The following Manifest cleanups where applied:

  • Calculate 'uses' directive for public packages
  • Remove unused dependencies

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 15, 2025

Test Results

  807 files  ±0    807 suites  ±0   1h 14m 1s ⏱️ -34s
2 200 tests ±0  2 151 ✅ ±0   49 💤 ±0  0 ❌ ±0 
6 612 runs  ±0  6 463 ✅ ±0  149 💤 ±0  0 ❌ ±0 

Results for commit 1d285fb. ± Comparison against base commit 4c55069.

♻️ This comment has been updated with latest results.

org.eclipse.osgi.util,
org.osgi.framework;version="[1.6.0,2)",
org.osgi.framework.hooks.resolver;version="[1.0,2.0)",
org.osgi.framework.namespace;version="1.0.0",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has to be fixed in PDE, even though in general it is correct that org.osgi.framework.namespace is not used because we only have constant values that are all get inlined by the compiler.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eclipse-equinox-bot eclipse-equinox-bot force-pushed the clean-code/bundles/org.eclipse.equinox.console branch 4 times, most recently from 3662bdc to e45cdda Compare July 21, 2025 03:15
@eclipse-equinox-bot eclipse-equinox-bot force-pushed the clean-code/bundles/org.eclipse.equinox.console branch from e45cdda to 1d285fb Compare July 22, 2025 03:07
@laeubi laeubi merged commit 6916f4a into master Jul 22, 2025
29 of 30 checks passed
@laeubi laeubi deleted the clean-code/bundles/org.eclipse.equinox.console branch July 22, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants