Clean Code for bundles/org.eclipse.equinox.console#1078
Merged
Conversation
laeubi
requested changes
Jul 15, 2025
| org.eclipse.osgi.util, | ||
| org.osgi.framework;version="[1.6.0,2)", | ||
| org.osgi.framework.hooks.resolver;version="[1.0,2.0)", | ||
| org.osgi.framework.namespace;version="1.0.0", |
Member
There was a problem hiding this comment.
This has to be fixed in PDE, even though in general it is correct that org.osgi.framework.namespace is not used because we only have constant values that are all get inlined by the compiler.
Member
There was a problem hiding this comment.
This should fix the issue:
3662bdc to
e45cdda
Compare
e45cdda to
1d285fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following cleanups were applied:
The following Manifest cleanups where applied: