Fix warning message on Mac about secure coding not enabled

[Phillipus]

• See [Mac Sonoma] "WARNING: Secure coding is not enabled for restorable state" warning message #630

• On macOS 14 and later a warning message is written to console: "WARNING: Secure coding is not enabled for restorable state! Enable secure coding by implementing NSApplicationDelegate.applicationSupportsSecureRestorableState: and returning YES."

• This adds an NSApplicationDelegate that implements applicationSupportsSecureRestorableState

• I don't know if the additional code could be better placed. Feedback welcome!

[github-actions]

Test Results

  660 files  +  220    660 suites  +220   1h 11m 18s ⏱️ + 21m 49s
2 195 tests ±    0  2 148 ✅ +    1   47 💤  -  1  0 ❌ ±0 
6 729 runs  +2 243  6 586 ✅ +2 196  143 💤 +47  0 ❌ ±0 

Results for commit d15cb06. ± Comparison against base commit c4be7f2.

[HannesWell]

@sravanlakkimsetti can you review this?

@Phillipus thank you for being pro-active on this topic. You can try out the executables/launcher-libraries archived in the Jenkins verification build to test if it has the desired effect.

[Phillipus]

@Phillipus thank you for being pro-active on this topic. You can try out the executables/launcher-libraries archived in the Jenkins verification build to test if it has the desired effect.

@HannesWell Thanks for the heads up. I had already compiled and built the so file locally and tested it. But I also tested the one you refer to at Jenkins here. That does indeed have the desired effect.

[Phillipus]

I'm not certain that setting an app delegate where I have set it in the PR is the right place. There are places that reference a an existing delegate:

equinox/features/org.eclipse.equinox.executable.feature/library/cocoa/eclipseCocoa.c

Lines 197 to 198 in c4be7f2

	NSObject *delegate = [[NSApplication sharedApplication] delegate];
	if (delegate != NULL && [delegate respondsToSelector: @selector(application:openFiles:)]) {

equinox/features/org.eclipse.equinox.executable.feature/library/cocoa/eclipseCocoa.c

Lines 211 to 212 in c4be7f2

	NSObject *delegate = [[NSApplication sharedApplication] delegate];
	if (delegate != NULL && [delegate respondsToSelector: @selector(application:openUrls:)]) {

equinox/features/org.eclipse.equinox.executable.feature/library/cocoa/eclipseCocoa.c

Lines 234 to 235 in c4be7f2

	- (void) handleOpenUrlsTimer: (NSTimer *) timer {
	NSObject *delegate = [[NSApplication sharedApplication] delegate];

I'm not sure if setting a new delegate where I have might over-write a possibly existing one and then those functions might not work.

[Phillipus]

I did a check, and at the point where this PR sets the AppDelegate it is NULL but I'm not sure where or if an AppDelegate is set somewhere else. @lshanmug can you advise?

[sravanlakkimsetti]

@subyssurendran666 Can you please take a look?

Lets merge this after 4.32

[Phillipus]

Don't merge this one without further investigation. The equivalent implementation in SWT caused a crash to desktop. See eclipse-platform/eclipse.platform.swt#1240