Move product to common#712
Open
laeubi wants to merge 29 commits into
Open
Conversation
Change-Id: I776107680b86a43d201b760be935914fa352315f Signed-off-by: Simon Scholz <simon.scholz@vogella.com>
Change-Id: I776107680b86a43d201b760be935914fa352315f Signed-off-by: Simon Scholz <simon.scholz@vogella.com>
This affects all files except the .exsd , the "org.eclipse.jdt.ui.prefs"
and the pom.xml files.
Regular expression used:
find . -type f ! -name "*.exsd" ! -name "org.eclipse.jdt.ui.prefs" -exec
sed -i 's/Eclipse Public License v1.0/Eclipse Public License 2.0/g' {}
+
find . -type f ! -name "*.exsd" ! -name "org.eclipse.jdt.ui.prefs"
-exec sed -i -E
's/([[:blank:]]*[^[:blank:]])*([[:blank:]]*)http:\/\/www.eclipse.org\/legal\/epl-v10.html/\1\2https:\/\/www.eclipse.org\/legal\/epl-2.0\/\
\1\
\1\2SPDX-License-Identifier: EPL-2.0/' {} +
# Get rid of the All rights reserved
find . -type f ! -name "*.exsd" ! -name "org.eclipse.jdt.ui.prefs" !
-name "pom.xml" -exec sed -i -E
's/([[:blank:]]*[^[:blank:]])*([[:blank:]]*)(All rights reserved.
)/\1\n\1\2/' {} +
Change-Id: I9ca35a0f032a75a181f7dc6268989d848a210963
Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
This affects all files except the .exsd , the "org.eclipse.jdt.ui.prefs"
and the pom.xml files.
Regular expression used:
find . -type f ! -name "*.exsd" ! -name "org.eclipse.jdt.ui.prefs" -exec
sed -i 's/Eclipse Public License v1.0/Eclipse Public License 2.0/g' {}
+
find . -type f ! -name "*.exsd" ! -name "org.eclipse.jdt.ui.prefs"
-exec sed -i -E
's/([[:blank:]]*[^[:blank:]])*([[:blank:]]*)http:\/\/www.eclipse.org\/legal\/epl-v10.html/\1\2https:\/\/www.eclipse.org\/legal\/epl-2.0\/\
\1\
\1\2SPDX-License-Identifier: EPL-2.0/' {} +
# Get rid of the All rights reserved
find . -type f ! -name "*.exsd" ! -name "org.eclipse.jdt.ui.prefs" !
-name "pom.xml" -exec sed -i -E
's/([[:blank:]]*[^[:blank:]])*([[:blank:]]*)(All rights reserved.
)/\1\n\1\2/' {} +
Change-Id: I9ca35a0f032a75a181f7dc6268989d848a210963
Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
Member
Author
|
The ECA check fails as this seem to contain some verrrryyyy old commits that don't have a suitable author to be identified by the check. |
laeubi
force-pushed
the
move_product_to_common
branch
from
9e040eb to
2d3f1e1
Compare
Member
Author
|
Only the usual TCK fail, @tjwatson what did you think? |
Contributor
I'm concerned that we are not solving the real problem. In the long run it may be best to move all the split "parts" of org.eclipse.core.runtime back to org.eclipse.core.runtime bundle in platform. |
Member
Author
I don't think that's really possible as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we have a split-package between equinox-common and eclipse-platform.
This moves the interface
from platform to commons to reduce the amount of split-api, I tried to recover the history as much as possible for these files even though there is not much changed in the last years. If anyone wants to verify this it would be appreciated.
When this PR is merged the classes can be deleted from the platform bundle making it only 5 classes left to migrate before the split is resolved.