Skip to content

Commit ce80507

Browse files
committed
Remove dead commented-out code in DiscoveryInstallOperation
The two commented-out blocks have been unreachable since 2019 (commit 1139fc5). One block sits after a return statement; the other is an old ProvisioningUtil call replaced by RepositoryTracker. Both are safe to delete.
1 parent e3b8d67 commit ce80507

1 file changed

Lines changed: 0 additions & 30 deletions

File tree

bundles/org.eclipse.equinox.p2.ui.discovery/src/org/eclipse/equinox/internal/p2/ui/discovery/operations/DiscoveryInstallOperation.java

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -121,33 +121,6 @@ public IInstallableUnit[] computeInstallableUnits(SubMonitor monitor) throws Cor
121121
checkForUnavailable(installableUnits);
122122
return installableUnits.toArray(new IInstallableUnit[installableUnits.size()]);
123123

124-
// MultiStatus status = new MultiStatus(DiscoveryUi.ID_PLUGIN, 0,
125-
// Messages.PrepareInstallProfileJob_ok, null);
126-
// ius = installableUnits.toArray(new
127-
// IInstallableUnit[installableUnits.size()]);
128-
// ProfileChangeRequest profileChangeRequest =
129-
// InstallAction.computeProfileChangeRequest(ius, profileId,
130-
// status, new SubProgressMonitor(monitor, installableConnectors.size()));
131-
// if (status.getSeverity() > IStatus.WARNING) {
132-
// throw new CoreException(status);
133-
// }
134-
// if (profileChangeRequest == null) {
135-
// // failed but no indication as to why
136-
// throw new CoreException(new Status(IStatus.ERROR, DiscoveryUi.ID_PLUGIN,
137-
// Messages.PrepareInstallProfileJob_computeProfileChangeRequestFailed, null));
138-
// }
139-
// PlannerResolutionOperation operation = new PlannerResolutionOperation(
140-
// Messages.PrepareInstallProfileJob_calculatingRequirements, profileId,
141-
// profileChangeRequest, null,
142-
// status, true);
143-
// IStatus operationStatus = operation.execute(new SubProgressMonitor(monitor,
144-
// installableConnectors.size()));
145-
// if (operationStatus.getSeverity() > IStatus.WARNING) {
146-
// throw new CoreException(operationStatus);
147-
// }
148-
//
149-
// plannerResolutionOperation = operation;
150-
151124
} catch (URISyntaxException e) {
152125
// should never happen, since we already validated URLs.
153126
throw new CoreException(new Status(IStatus.ERROR, DiscoveryUi.ID_PLUGIN,
@@ -282,9 +255,6 @@ private List<IMetadataRepository> addRepositories(SubMonitor monitor)
282255
if (repositoryLocations.add(uri)) {
283256
checkCancelled(monitor);
284257
repositoryTracker.addRepository(uri, null, session);
285-
// ProvisioningUtil.addMetaDataRepository(url.toURI(), true);
286-
// ProvisioningUtil.addArtifactRepository(url.toURI(), true);
287-
// ProvisioningUtil.setColocatedRepositoryEnablement(url.toURI(), true);
288258
}
289259
monitor.worked(1);
290260
}

0 commit comments

Comments
 (0)