Remove dead commented-out code in DiscoveryInstallOperation#1071
Open
vogella wants to merge 1 commit into
Open
Remove dead commented-out code in DiscoveryInstallOperation#1071vogella wants to merge 1 commit into
vogella wants to merge 1 commit into
Conversation
The two commented-out blocks have been unreachable since 2019 (commit 1139fc5). One block sits after a return statement; the other is an old ProvisioningUtil call replaced by RepositoryTracker. Both are safe to delete.
vogella
force-pushed
the
remove-dead-code-discovery-install
branch
from
48fd0b3 to
ce80507
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two blocks of commented-out code in
DiscoveryInstallOperationhave been dead since July 2019 (commit 1139fc5, "Convert to the generic IProvisioningAgent.getService()"). One block sits after areturnstatement and can never execute; the other is an oldProvisioningUtilcall that was superseded byRepositoryTracker. Both are pure clutter with no chance of being re-enabled as-is.