Support plugin_customization.ini for p2 trust preferences#1075
Merged
vogella merged 2 commits intoMay 30, 2026
Conversation
The "trust always" preferences (trustAlways for artifacts and trustAllAuthorities for authorities) were read only from the ProfileScope node via IEclipsePreferences.getBoolean(), which by contract only consults that single node. Values seeded into the Eclipse DefaultScope via a product's plugin_customization.ini were therefore unreachable, even though docs/Trust_Settings.md documents them as the way to configure defaults. Route both reads through IPreferencesService so the lookup chains through ProfileScope first (user-set values still win) and falls through to DefaultScope (where plugin_customization.ini lands). Writes still go to ProfileScope and are unchanged. This mirrors the fix in eclipse-platform/eclipse.platform.ui#1795 for the e4 workbench renderer preferences.
vogella
force-pushed
the
fix-p2-trust-prefs-defaultscope
branch
from
6eccb37 to
739d6ff
Compare
Contributor
Author
|
@merks AFAIK you implement this, have a look if you have the time. |
Contributor
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
Contributor
|
This seems reasonable. Note that |
Contributor
Author
Thanks, AFAICS that's already wired up via p2.trustedAuthorities in AuthorityChecker and noted in Trust_Settings.md. |
Member
|
This PR caused regression, see #1098 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
p2's "trust always" preferences (
trustAlwaysfor artifacts,trustAllAuthoritiesfor authorities) were read withIEclipsePreferences.getBoolean()on a singleProfileScopenode, which by contract never falls through to other scopes. Values seeded intoDefaultScopevia a product'splugin_customization.iniwere therefore unreachable, even thoughdocs/Trust_Settings.mddocuments that as the configuration path.Both
isTrustAlways()methods now read throughIPreferencesServicewith{ ProfileScope, DefaultScope.INSTANCE }, so user-set profile values still win andplugin_customization.inidefaults are honored as a fallback. Writes still go to ProfileScope and are unchanged.Mirrors the fix in eclipse-platform/eclipse.platform.ui#1795 for the e4 workbench renderer preferences.