Skip to content

Migrate AutomaticUpdateScheduler from IStartup to OSGi EventHandler#400

Open
HannesWell wants to merge 1 commit into
eclipse-equinox:masterfrom
HannesWell:update-scheduler-as-eventHandler
Open

Migrate AutomaticUpdateScheduler from IStartup to OSGi EventHandler#400
HannesWell wants to merge 1 commit into
eclipse-equinox:masterfrom
HannesWell:update-scheduler-as-eventHandler

Conversation

@HannesWell
Copy link
Copy Markdown
Member

@HannesWell HannesWell commented Dec 9, 2023

... for the UIEvents.UILifeCycle.APP_STARTUP_COMPLETE event.

This is a less Eclipse specific approach and also prevents the user from disabling the start-up task.
The automatic search for updates can still be disabled.

Based on the work in eclipse-platform/eclipse.platform.ui#1362.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 9, 2023 •
edited
Loading

Test Results

   18 files  ±0     18 suites  ±0   30m 13s ⏱️ + 1m 31s
2 169 tests ±0  2 166 ✅ ±0  3 💤 ±0  0 ❌ ±0 
5 161 runs  ±0  5 152 ✅ ±0  9 💤 ±0  0 ❌ ±0 

Results for commit 39aee07. ± Comparison against base commit e3b8d67.

♻️ This comment has been updated with latest results.

iloveeclipse
iloveeclipse reviewed Dec 9, 2023
View reviewed changes
Comment thread ...scheduler/src/org/eclipse/equinox/internal/p2/ui/sdk/scheduler/AutomaticUpdateScheduler.java

@Override
public void earlyStartup() {
public void handleEvent(Event event) {
Copy link
Copy Markdown
Member

@iloveeclipse iloveeclipse Dec 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we check if automated updates are disabled before starting the job?

@iloveeclipse
Copy link
Copy Markdown
Member

iloveeclipse commented Dec 9, 2023

With "Early startup" one could disable updates job. Now it is always started even if updates are not enabled. I think this is a regression.

@HannesWell HannesWell force-pushed the update-scheduler-as-eventHandler branch from 52b2783 to 613cd77 Compare December 9, 2023 14:17
@HannesWell
Copy link
Copy Markdown
Member Author

HannesWell commented Dec 9, 2023 •
edited
Loading

With "Early startup" one could disable updates job. Now it is always started even if updates are not enabled. I think this is a regression.

There is a dedicated preference to control the automatic search for updates:
grafik

So yes now the job always runs, but the job still respects the preference so if you have disabled updates, it is basically a noop.

I can also refactor this to only run the job if the preference is enabled, but I'm not sure what's best in regard of IDE start-up speed. Check the preference before running the job or within the job and potentially exit early?
Of course starting a job has an overhead but so does checking a preference.

@HannesWell HannesWell force-pushed the update-scheduler-as-eventHandler branch from 613cd77 to b3215ef Compare January 19, 2024 17:57
@laeubi
Copy link
Copy Markdown
Member

laeubi commented Jun 16, 2024

@HannesWell @iloveeclipse should we further work on this or should we close this?

@HannesWell HannesWell force-pushed the update-scheduler-as-eventHandler branch 2 times, most recently from bfe3d8e to f5213b9 Compare October 12, 2024 11:27
@HannesWell
Copy link
Copy Markdown
Member Author

HannesWell commented Oct 12, 2024

@HannesWell @iloveeclipse should we further work on this or should we close this?

I would still be in favor of having this and was waiting for the response of @iloveeclipse on my previous response:

I can also refactor this to only run the job if the preference is enabled, but I'm not sure what's best in regard of IDE start-up speed. Check the preference before running the job or within the job and potentially exit early?
Of course starting a job has an overhead but so does checking a preference.

@eclipse-equinox-bot
Copy link
Copy Markdown
Contributor

eclipse-equinox-bot commented Oct 12, 2024 •
edited
Loading

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.equinox.p2.ui.sdk.scheduler/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch 
From bb09f38612e3dd269472533abb01dd5313f69ec0 Mon Sep 17 00:00:00 2001
From: Eclipse Equinox Bot <equinox-bot@eclipse.org>
Date: Tue, 15 Oct 2024 17:34:06 +0000
Subject: [PATCH] Version bump(s) for 4.34 stream


diff --git a/bundles/org.eclipse.equinox.p2.ui.sdk.scheduler/META-INF/MANIFEST.MF b/bundles/org.eclipse.equinox.p2.ui.sdk.scheduler/META-INF/MANIFEST.MF
index 011622b8c..106de039f 100644
--- a/bundles/org.eclipse.equinox.p2.ui.sdk.scheduler/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.equinox.p2.ui.sdk.scheduler/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %bundleName
 Bundle-SymbolicName: org.eclipse.equinox.p2.ui.sdk.scheduler;singleton:=true
-Bundle-Version: 1.6.300.qualifier
+Bundle-Version: 1.6.400.qualifier
 Bundle-Activator: org.eclipse.equinox.internal.p2.ui.sdk.scheduler.AutomaticUpdatePlugin
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
-- 
2.46.2

Further information are available in Common Build Issues - Missing version increments.

@HannesWell HannesWell force-pushed the update-scheduler-as-eventHandler branch 2 times, most recently from b426237 to 4a67dd8 Compare October 15, 2024 17:31
@iloveeclipse
Copy link
Copy Markdown
Member

iloveeclipse commented Oct 15, 2024

Check the preference before running the job or within the job and potentially exit early?
Of course starting a job has an overhead but so does checking a preference.

I would avoid starting job if possible, because compared with a single preference check extra job adds extra complexity for the overall IDE startup, uses shared resources (worker pool), adds async execution effects.

@vogella
Copy link
Copy Markdown
Contributor

vogella commented Dec 6, 2024

@HannesWell could you move the preference check before starting the job? Would be nice to have this finished.

@laeubi
Copy link
Copy Markdown
Member

laeubi commented Nov 11, 2025

@HannesWell my suggestion would be to either finish this for 2026-03 M1 or we close the PR as it is celebrating its second anniversary soon.

@vogella
Copy link
Copy Markdown
Contributor

vogella commented May 14, 2026

2026-03 M1

Lets try 2026-09 M1

@vogella vogella force-pushed the update-scheduler-as-eventHandler branch from 8e319bf to cca7da1 Compare May 14, 2026 04:48
@vogella
Copy link
Copy Markdown
Contributor

vogella commented May 14, 2026

API errors showing up in the full CI build are unrelated to this change, ,they come from other bundles.

@HannesWell @vogella
Migrate AutomaticUpdateScheduler from IStartup to OSGi EventHandler
39aee07 
... for the UIEvents.UILifeCycle.APP_STARTUP_COMPLETE event.

This is a less Eclipse specific approach and also prevents the user from
disabling the start-up task.
The automatic search for updates can still be disabled.
@vogella vogella force-pushed the update-scheduler-as-eventHandler branch from cca7da1 to 39aee07 Compare May 21, 2026 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iloveeclipse iloveeclipse iloveeclipse left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@HannesWell @iloveeclipse @laeubi @eclipse-equinox-bot @vogella