Use absolute paths to invoke reg and find#824
Merged
Conversation
- Tests are failing depending on what is on the system PATH environment variable, i.e., the script find the wrong find executable, the one from git bash rather than the windows native find. - Do the same for `reg`.
Test Results 365 files ±0 365 suites ±0 42m 4s ⏱️ + 1m 30s For more details on these failures, see this check. Results for commit 178bfea. ± Comparison against base commit 9ab47de. |
Contributor
Author
|
The three failing tests for the windows native registry stopped failing. |
Member
|
Should we try to revert this to see if this is also fixed by eclipse-platform/eclipse.platform.releng.aggregator#3042? |
Contributor
Author
|
It’s a real problem that the script assumes the right things are on the path first. Launch eclipse from gitbash and this touch point will fail. How many other places make bad assumptions I don’t know but best to fix the assumption than make the environment conform to the assumption. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reg.